Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windowshosting package may depend on incorrect runtimepackagestore version #32

Open
jberezanski opened this issue May 30, 2018 · 0 comments

Comments

@jberezanski
Copy link
Collaborator

Scenario:

  1. aspnetcore-runtimepackagestore is forcibly updated and gets a package fix version, e.g. 2.1.0.20180531
  2. dotnetcore-windowshosting is also forcibly updated and gets the same package fix version, e.g. 2.1.0.20180531
  3. dotnetcore-windowshosting AU script runs au_GetLatest from aspnetcore-runtimepackagestore to determine the appropriate dependency version to use
  4. au_GetLatest from aspnetcore-runtimepackagestore correctly returns 2.1.0, because that is the actual latest released software version
  5. result: dotnetcore-windowshosting 2.1.0.20180531 depends on aspnetcore-runtimepackagestore 2.1.0 instead of 2.1.0.20180531

I believe the correct way to handle this would be to:

  1. in UpdateAll.ps1, ensure aspnetcore-runtimepackagestore is processed earlier than dotnetcore-windowshosting,
  2. in dotnetcore-windowshosting AU script, obtain the latest aspnetcore-runtimepackagestore version from the aspnetcore-runtimepackagestore stream json state file instead of invoking au_GetLatest from that package.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant