From 91c5d6449bf221055d0c8a1216b9d68a98760134 Mon Sep 17 00:00:00 2001 From: Douglas Naphas Date: Mon, 25 Mar 2024 22:28:46 -0400 Subject: [PATCH] Remove v1 links from the Home Page gh-572 The v1 flow is too brittle. It will be confusing having login be meaningful for v1 and v2 simultaneously. Any shortcomings of v2 do not outweigh the risk that v1 carries of lockout. --- .github/workflows/feature-branch.yml | 24 --------------- frontend/src/components/HomePage.js | 39 ------------------------ frontend/src/components/HomePage.test.js | 16 ---------- 3 files changed, 79 deletions(-) diff --git a/.github/workflows/feature-branch.yml b/.github/workflows/feature-branch.yml index 7fcebd7d..fd4e3ba8 100644 --- a/.github/workflows/feature-branch.yml +++ b/.github/workflows/feature-branch.yml @@ -132,30 +132,6 @@ jobs: working-directory: content run: | npm run deploy - itest: - runs-on: ubuntu-latest - permissions: - id-token: write - contents: read - needs: [frontend, content] - steps: - - uses: actions/checkout@v4 - - name: Configure AWS Credentials - uses: aws-actions/configure-aws-credentials@v4 - with: - role-to-assume: ${{ vars.DEV_ROLE_ARN }} - aws-region: us-east-1 - - name: Install itest - working-directory: itest - run: | - npm install - - name: Run smoke test (dev account) - working-directory: itest - env: - AWS_DEFAULT_REGION: "us-east-1" - AWS_REGION: "us-east-1" - run: | - npm run itest itest-links-2023: runs-on: ubuntu-latest permissions: diff --git a/frontend/src/components/HomePage.js b/frontend/src/components/HomePage.js index e9677f34..e3a2d350 100644 --- a/frontend/src/components/HomePage.js +++ b/frontend/src/components/HomePage.js @@ -67,45 +67,6 @@ class HomePage extends Component { {createHaggadahLinkText} -
-
- -
-
-
- -
-
-
- -

{!user && (
diff --git a/frontend/src/components/HomePage.test.js b/frontend/src/components/HomePage.test.js index 282eeb3b..fe55e8d0 100644 --- a/frontend/src/components/HomePage.test.js +++ b/frontend/src/components/HomePage.test.js @@ -16,22 +16,6 @@ describe("", () => { const loginText = "Log in"; const logoutText = "Log out"; - test("Should render buttons with the right links", () => { - const storage = { removeItem: jest.fn() }; - render( - - - - ); - const leadASederByVideoButton = screen - .getByText(leadASederByVideoText) - .closest("a"); - expect(leadASederByVideoButton).toHaveTextContent(leadASederByVideoText); - expect(leadASederByVideoButton).toHaveAttribute("href", "/explain-video"); - const joinASederButton = screen.getByText(joinASederText).closest("a"); - expect(joinASederButton).toHaveTextContent(joinASederText); - expect(joinASederButton).toHaveAttribute("href", "/enter-room-code"); - }); test("The Log In button should have an href to the login page", () => { const storage = { removeItem: jest.fn() }; render(