Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly default :npm-deps to true #200

Open
mfikes opened this issue Oct 15, 2018 · 0 comments
Open

Explicitly default :npm-deps to true #200

mfikes opened this issue Oct 15, 2018 · 0 comments

Comments

@mfikes
Copy link

mfikes commented Oct 15, 2018

With the next release of ClojureScript, the default of :npm-deps will change from true to false.

A consequence is that Reagent-based apps will exhibit an issue if users upgrade to this (future) ClojureScript version (this is with lein figwheel ios):

----  Could not Analyze  target/ios/reagent/impl/component.cljs  ----

  No such namespace: create-react-class, could not locate create_react_class.cljs, create_react_class.cljc, or JavaScript source providing "create-react-class" (Please check that namespaces with dashes use underscores in the ClojureScript file name)

The fix is to simply explicitly specify the :npm-deps value to true.

We many not want to do this until bhauman/lein-figwheel#715

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant