Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DropboxOAuth2Helper.ProcessCodeFlowAsync()'s state parameter is lost/ignored #248

Open
MarkMichaelis opened this issue Jun 20, 2021 · 1 comment
Labels

Comments

@MarkMichaelis
Copy link

Describe the bug
When invoking DropboxOAuth2Helper.ProcessCodeFlowAsync(Uri responseUri, string appKey, string appSecret, string redirectUri = null, string state = null, HttpClient client = null, string codeVerifier = null), the one with the state parameter, the state parameter is ignored/abandoned.

To Reproduce
Invoke the DropboxOAuth2Helper.ProcessCodeFlowAsync() (the one that includes a state parameter), and then check the State property on the response. The states should be the same value as passed in but, instead, the value is null.

Expected Behavior
When calling ProcessCodeFlowAsync() with a state parameter the returned OAuth2Response should include the state.

Actual Behavior
When calling ProcessCodeFlowAsync() with a state parameter the returned OAuth2Response's State property is null

Screenshots
If applicable, add screenshots to help explain your problem.

Versions

  • What version of the SDK are you using?
    v6.8 but I assume the problem has been around for some time.

Additional context
Notice that the OAuthPKCE sample does not test the state whereas the SimpleTest sample does.

@MarkMichaelis MarkMichaelis changed the title State is lost/ignored DropboxOAuth2Helper.ProcessCodeFlowAsync()'s state parameter is lost/ignored Jun 20, 2021
@greg-db
Copy link
Contributor

greg-db commented Jun 21, 2021

Thanks! We'll look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants