Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove api_connection() method from Salesforce source #1050

Open
mgardzinski opened this issue Sep 24, 2024 · 0 comments
Open

Remove api_connection() method from Salesforce source #1050

mgardzinski opened this issue Sep 24, 2024 · 0 comments
Labels
2.0 backlog Backlog for logic issues in connectors after migration 2.0 viadot 2.0 enhancement New feature or request

Comments

@mgardzinski
Copy link

Comment from @trymzet:
This function should just be part of to_df(), or at least renamed to to_records() if you want to have an intermediate representation. If you want to do that then pls also add proper return type. Also, there's no need to keep data as an attribute (self.data) - just return it directly in to_df() or to_records() (if you wish to keep this one). Eg.

Suggested change:

def to_records(self, ...) -> list[dict[str, Any]]:
    ...
   return records

def to_df(self, ...) -> pd.DataFrame:
    records = self.to_records(...)
    df = pd.DataFrame(records)
    ...
@mgardzinski mgardzinski added the 2.0 backlog Backlog for logic issues in connectors after migration label Sep 24, 2024
@trymzet trymzet added the enhancement New feature or request label Sep 30, 2024
@trymzet trymzet changed the title Integrate api_connection() method into to_df() in Salesforce source Remove api_connection() method from Salesforce source Sep 30, 2024
@trymzet trymzet added the 2.0 viadot 2.0 label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.0 backlog Backlog for logic issues in connectors after migration 2.0 viadot 2.0 enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants