Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils.anonymize_df() - rename days param to older_than_days #1058

Open
gwieloch opened this issue Sep 26, 2024 · 2 comments
Open

utils.anonymize_df() - rename days param to older_than_days #1058

gwieloch opened this issue Sep 26, 2024 · 2 comments
Labels
2.0 backlog Backlog for logic issues in connectors after migration 2.0 viadot 2.0 enhancement New feature or request

Comments

@gwieloch
Copy link
Contributor

gwieloch commented Sep 26, 2024

1 issue:
@trymzet trymzet 3 days ago
Can you rename this to older_than_days pls? I just had too read the code closely to understand what this param actually means because days is so generic it might as well be x, so I found a better name for it.

file to change: src/viadot/utils.py
task : anonymize_df

action: change var name from days to older_than_days

#1040 (comment)
#1040 (comment)

@gwieloch gwieloch added enhancement New feature or request 2.0 backlog Backlog for logic issues in connectors after migration labels Sep 26, 2024
@gwieloch
Copy link
Contributor Author

@gwieloch
Copy link
Contributor Author

2nd issue:

elif method == "hash": df.loc[to_hash, columns] = df.loc[to_hash, columns].apply( lambda x: x.apply(hash)
@trymzet trymzet last week
Not sure you want to do it this way -- python's built-in hash function does not generate the same output from the same input, so even if your data is the same, the calculated hashes would be different every time you run this function, which could be problematic for some use cases. To produce stable hashes, you need to use hashlib.

@gwieloch gwieloch changed the title modify variable name in anonymize_df task in viadot.utils modify anonymize_df task in viadot.utils Sep 26, 2024
@trymzet trymzet changed the title modify anonymize_df task in viadot.utils utils.anonymize_df() - rename days param to older_than_days Sep 27, 2024
@trymzet trymzet added the 2.0 viadot 2.0 label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.0 backlog Backlog for logic issues in connectors after migration 2.0 viadot 2.0 enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants