New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

`Mediatool` - rename `method` param to `endpoint` #1060

Open

mgardzinski opened this issue Sep 26, 2024 · 0 comments

Labels

2.0 backlog 2.0 enhancement

mgardzinski commented Sep 26, 2024

comments @trymzet :
There is an existing standard term for this https://blog.postman.com/what-is-an-api-endpoint/, so (applying the other feedback as well) this code could be simplified to

#1038 (comment)

Suggested changeg:

# first method ORGANIZATIONS
method = "organizations"
organizations_data = mediatool.api_connection(get_data_from=method)
df_organizations = mediatool.to_df(data=organizations_data, column_suffix=method)
df_organizations = mediatool.to_df(endpoint="organizations")

mgardzinski added the 2.0 backlog label

mgardzinski mentioned this issue

✨ Add Mediatool source and Prefect tasks #1038

Merged

5 tasks

trymzet changed the title ~~Simplified code in Mediatool source~~ Mediatool - rename method param to endpoint

trymzet added 2.0 enhancement labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment