Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mediatool - move connector logic from Prefect task to the connector #1061

Open
mgardzinski opened this issue Sep 26, 2024 · 0 comments
Open

Mediatool - move connector logic from Prefect task to the connector #1061

mgardzinski opened this issue Sep 26, 2024 · 0 comments
Labels
2.0 backlog Backlog for logic issues in connectors after migration 2.0 viadot 2.0 bug Something isn't working orchestration Issues related to the orchestration layer.

Comments

@mgardzinski
Copy link

@trymzet comment:
It seems like all this logic should be handled within Mediatool.to_df(), which should only be called here in the task, with whichever params are required? Or why is part of the logic in the source and part in the task?

#1038 (comment)
@mgardzinski mgardzinski added the 2.0 backlog Backlog for logic issues in connectors after migration label Sep 26, 2024
@mgardzinski mgardzinski mentioned this issue Sep 26, 2024
Merged
5 tasks
@trymzet trymzet changed the title Move Logic to Mediatool.to_df() for Simplicity Mediatool - move connector logic from Prefect task to the source Sep 27, 2024
@trymzet trymzet changed the title Mediatool - move connector logic from Prefect task to the source Mediatool - move connector logic from Prefect task to the connector Sep 27, 2024
@trymzet trymzet added 2.0 viadot 2.0 bug Something isn't working orchestration Issues related to the orchestration layer. labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.0 backlog Backlog for logic issues in connectors after migration 2.0 viadot 2.0 bug Something isn't working orchestration Issues related to the orchestration layer.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@trymzet @mgardzinski