Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add favicon.ico to exist-db.org homepage #35

Open
joewiz opened this issue Feb 15, 2022 · 1 comment
Open

Add favicon.ico to exist-db.org homepage #35

joewiz opened this issue Feb 15, 2022 · 1 comment

Comments

@joewiz
Copy link
Member

joewiz commented Feb 15, 2022

@lguariento said:

PS: well, there's still the ever-present 404 for the favicon. :)

I responded:

Ah yes, that's an issue with the configuration of the exist-db.org server. It should forward the request for http://exist-db.org/favicon.ico to the ico file in eXist's jetty config directories https://github.com/eXist-db/exist/blob/develop/exist-jetty-config/src/main/resources/org/exist/jetty/etc/webapps/portal/resources/exist_icon_16x16.ico.

p.s. I know this is an exist-db.org server configuration issue, not an issue with this app - but the repo is called "website" and there's no dedicated repo for exist-db.org server issues.

@joewiz
Copy link
Member Author

joewiz commented Feb 21, 2022

Actually, I think all we need is to add:

<link rel="shortcut icon" href="resources/images/exist_icon_16x16.ico">

... to the page template, ensuring that the referenced image is there.

This is already working on https://exist-db.org/exist/apps/public-repo/.

@joewiz joewiz changed the title Add favicon.ico support on exist-db.org Add favicon.ico to exist-db.org homepage Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant