Add UCRT64 build option #567
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses a workflow option to build as UCRT64 instead of MINGW64. The BUILD_NAME variable gets updated to have
ucrt-beforex64and the build script replacesw64-x86_64withw64-ucrt-x86_64if$USE_UCRTequals1.It built successfully, but I figured you might want to be able to have it built separately to help make sure there's not any bugs specific to a particular compilation process.
Oh, and also allows for local dependencies lists in the build file. I was initially going to do some weird thing where there was a separate file for UCRT64-specific builds but came up with just altering the
sedcommand based on an env variable instead. However, I decided it would still be nice to be able to have some sort of manual override for that if necessary.