Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dealing with lack of internet while knitting the vignettes #476

Open
IndrajeetPatil opened this issue Jan 19, 2024 · 4 comments
Open

Dealing with lack of internet while knitting the vignettes #476

IndrajeetPatil opened this issue Jan 19, 2024 · 4 comments
Labels
Docs 📚 Improvements or additions to documentation

Comments

@IndrajeetPatil
Copy link
Member

My hunch is that this was a temporary issue where the internet connection might have been down during the check. But we should anticipate and deal with this anyway. That is, we should evaluate this vignette, or at least the relevant chunks, only when internet is available (using curl::has_internet()).

cf. https://www.r-project.org/nosvn/R.check/r-oldrel-windows-x86_64/datawizard-00check.html

Version: 0.9.1
Check: re-building of vignette outputs
Result: ERROR 
  Error(s) in re-building vignettes:
  --- re-building 'selection_syntax.Rmd' using rmarkdown
  --- finished re-building 'selection_syntax.Rmd'
  
  --- re-building 'standardize_data.Rmd' using rmarkdown
  
  Quitting from lines 204-218 [unnamed-chunk-9] (standardize_data.Rmd)
  Error: processing vignette 'standardize_data.Rmd' failed with diagnostics:
  cannot open the connection to 'https://raw.githubusercontent.com/neuropsychology/psycho.R/master/data/emotion.rda'
  --- failed re-building 'standardize_data.Rmd'
@IndrajeetPatil IndrajeetPatil changed the title Dealing with a lack of internet while knitting the selection syntax vignette Dealing with lack of internet while knitting the selection syntax vignette Jan 19, 2024
@IndrajeetPatil IndrajeetPatil changed the title Dealing with lack of internet while knitting the selection syntax vignette Dealing with lack of internet while knitting the vignettes Jan 19, 2024
@IndrajeetPatil
Copy link
Member Author

r-lib/actions#658 would come in handy to detect instances like these.

@IndrajeetPatil IndrajeetPatil added the Docs 📚 Improvements or additions to documentation label Jan 19, 2024
@strengejacke
Copy link
Member

Only downside is that the curl package has been a reason for failing tests for quite a long time (and still is?), e.g. https://github.com/easystats/performance/actions/runs/7439905072/job/20240326776

Or have we missed something here?

@IndrajeetPatil
Copy link
Member Author

Ah, no. This has nothing to do with {curl}; it is coming from {testthat}. I will have a look.

@strengejacke
Copy link
Member

strengejacke commented Jan 19, 2024

In this particular case, we could simply include the dataset in our package? @DominiqueMakowski are there licence reasons that prevent us from doing this?

It's just 11kb, and we would have another dataset at hand for example (I also think of teaching).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs 📚 Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants