Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Won't Compile #405

Open
Feel-ix-343 opened this issue Jan 10, 2024 · 2 comments · May be fixed by #406
Open

Won't Compile #405

Feel-ix-343 opened this issue Jan 10, 2024 · 2 comments · May be fixed by #406
Assignees
@ebkalderon
Labels
bug Something isn't working

Comments

@Feel-ix-343
Copy link

After this pr was merged, the crate will not compile.

I am getting this error


    Checking tower-lsp v0.20.0 (https://github.com/ebkalderon/tower-lsp?rev=49e1ce5#49e1ce54)
error[E0412]: cannot find type `WorkspaceDiagnosticRefresh` in this scope
   --> /home/felix/.cargo/git/checkouts/tower-lsp-c76aca49ec8e037c/49e1ce5/src/service/client.rs:350:29
    |
350 |         self.send_request::<WorkspaceDiagnosticRefresh>(()).await
    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
   ::: /home/felix/.cargo/registry/src/index.crates.io-6f17d22bba15001f/lsp-types-0.94.1/src/workspace_diagnostic.rs:120:1
    |
120 | pub struct WorkspaceDiagnosticReport {
    | ------------------------------------ similarly named struct `WorkspaceDiagnosticReport` defined here
    |
help: a struct with a similar name exists
    |
350 |         self.send_request::<WorkspaceDiagnosticReport>(()).await
    |                             ~~~~~~~~~~~~~~~~~~~~~~~~~
help: consider importing one of these items
    |
3   + use crate::request::WorkspaceDiagnosticRefresh;
    |
3   + use lsp_types::request::WorkspaceDiagnosticRefresh;
    |

For more information about this error, try `rustc --explain E0412`.
error: could not compile `tower-lsp` (lib) due to previous error
@Feel-ix-343 Feel-ix-343 changed the title Work Compile Won't Compile Jan 10, 2024
@ebkalderon ebkalderon added the bug Something isn't working label Jan 10, 2024
@ebkalderon ebkalderon self-assigned this Jan 10, 2024
@ebkalderon
Copy link
Owner

ebkalderon commented Jan 10, 2024 •
edited
Loading

Thanks for opening the ticket! Linking PR #385 over here for context, as a possible culprit. However, there are other build issues on main right now (CI is currently broken due to dashmap's recent change in MSRV, for instance), so I expect several build issues will be resolved at once.

@Feel-ix-343 Feel-ix-343 linked a pull request Jan 10, 2024 that will close this issue
Open
@Feel-ix-343
Copy link
Author

First, that PR removed the use lsp_types::request::*; in client.rs. This removed use lsp_types::request::WorkspaceDiagnosticRefresh; which was needed in the workspace_diagnostic_refresh function

The other issue is that dashmap needed rust 1.65.0

I created a pr that fixes both of these in this pr #406

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ebkalderon ebkalderon

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix compilation Feel-ix-343/tower-lsp
2 participants
@ebkalderon @Feel-ix-343