Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtering of elements at backend only #437

Open
mdanish98 opened this issue Sep 8, 2024 · 0 comments
Open

Filtering of elements at backend only #437

mdanish98 opened this issue Sep 8, 2024 · 0 comments
Assignees

Comments

@mdanish98
Copy link
Contributor

The current implementation of CrudRepository does filtering InMemory only. However, it should be done at backend side only based on specific implementation.

Affected methods:
getAll*() -> Pagination

User Story/Explanation

Rules

Refactor our implementation of the crud Repository
in our getAllAas, instead of findAll(), check out Spring crud Repository Method findAllByIds(Iterable id)

Entry Points

aasrepository: https://github.com/eclipse-basyx/basyx-java-server-sdk/blob/main/basyx.aasrepository/basyx.aasrepository-backend/src/main/java/org/eclipse/digitaltwin/basyx/aasrepository/backend/CrudAasRepository.java
submodelrepository: https://github.com/eclipse-basyx/basyx-java-server-sdk/blob/main/basyx.submodelrepository/basyx.submodelrepository-backend/src/main/java/org/eclipse/digitaltwin/basyx/submodelrepository/backend/CrudSubmodelRepository.java
dc repository: https://github.com/eclipse-basyx/basyx-java-server-sdk/blob/main/basyx.conceptdescriptionrepository/basyx.conceptdescriptionrepository-core/src/main/java/org/eclipse/digitaltwin/basyx/conceptdescriptionrepository/ConceptDescriptionRepository.java
discovery: https://github.com/eclipse-basyx/basyx-java-server-sdk/blob/main/basyx.aasdiscoveryservice/basyx.aasdiscoveryservice-backend/src/main/java/org/eclipse/digitaltwin/basyx/aasdiscoveryservice/backend/CrudAasDiscovery.java

Acceptance Criteria

Risks and Assumptions

References & Notes

Dependencies and Blockers

@mdanish98 mdanish98 self-assigned this Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant