Move MaterialUI to proper package.json #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Will Yang <william.yang@ericsson.com>
marcdumais-work
approved these changes
Sep 26, 2023
There was a problem hiding this comment.
LGTM, thanks for this contribution!
BTW, it would generally be desirable to use the latest baseline, for future pull-requests, or rebase the patch before posting it for review (e.g. git fetch origin master && git rebase origin/master).
However, I do not think it would change anything in this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MaterialUI was installed in the top-level node_modules. It's moved to the correct one in /packages/react-components/ where it's used.
This may fix eclipse-cdt-cloud/vscode-trace-extension/issues/175 according to this stackoverflow thread.
Signed-off-by: Will Yang william.yang@ericsson.com