Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update server URL: corner case with opened trace view(s) on one server but not the other #236

Open
marcdumais-work opened this issue Apr 10, 2024 · 0 comments

Comments

@marcdumais-work
Copy link
Contributor

While testing #229 I noticed that changing the server URL with some trace views opened, they would sometimes be updated with a confusing message.

To reproduce:

  • start 2 trace servers, on two machines or using a different port and workspace on the same machine
  • use the URL of server 1, open a trace
  • change URL to server 2 where the trace is not opened
  • the opened trace is updated with the following text: "Trace loaded successfully. To see available views, open the Trace Viewer."
    • I think it's good that the trace view is updated in a way to show that it's not currently opened in the current trace server, but the text in the view seems to have been intended for a different use-case?

If you switch back to server1 URL, the trace view is correctly restored.

switching trace server with opened trace view2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant