Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undo/redo is via shortcut is triggers multiple actions #874

Open
tortmayr opened this issue Jan 24, 2023 · 4 comments · May be fixed by eclipse-glsp/glsp-eclipse-integration#97
Open

Undo/redo is via shortcut is triggers multiple actions #874

tortmayr opened this issue Jan 24, 2023 · 4 comments · May be fixed by eclipse-glsp/glsp-eclipse-integration#97
Labels
bug Something isn't working eclipse help wanted Contributions are very welcome looking for sponsor Please consider sponsoring this feature

Comments

@tortmayr
Copy link
Contributor

Using the keyboard shortcuts for undo/redo results in multiple Undo/Redo actions for one key-stroke.

OS: Linux. Browser: Webkit
@tortmayr tortmayr added bug Something isn't working eclipse labels Jan 24, 2023
@planger planger added this to the 2.0.0 Release milestone Jan 26, 2023
@planger planger added help wanted Contributions are very welcome looking for sponsor Please consider sponsoring this feature labels Apr 26, 2023
@planger planger removed this from the 2.0.0 Release (Optional) milestone Jul 17, 2023
@N1k145
Copy link

N1k145 commented Apr 29, 2024

Hey @planger @tortmayr,

we are currently experiencing the same issue with all Key Bindings, like Ctr+H for opening the Eclipse Search.
From what I found, this is related to the BrowserKeyBindingForwarderInstaller as the Issue described there is only relevant for Chromium or Edge and not for WebKit. I would propose to add an if windows condition around the registration of this Installer.

I will open a PR soon.

N1k145 added a commit to N1k145/glsp-eclipse-integration that referenced this issue Apr 29, 2024
@N1k145
Fixes eclipse-glsp/glsp#874
e60c9a1 
Without this fix there are duplicated Key Binding Triggers on WebKit as the fix provided by BrowserKeyBindingForwarderInstaller is only an Issue on Chrome and Edge
@N1k145 N1k145 linked a pull request Apr 29, 2024 that will close this issue
Draft
2 tasks
@N1k145
Copy link

N1k145 commented Apr 30, 2024

I did some further investigations, it seems like this is an SWT Issue.
When I am using the Eclipse "Internal Web browser" on any generic webpage, I have the same behavior with Ctr+H.

On the GLSP Part, I was somehow able to reduce this issue by disabling the mentioned BrowserKeyBindingForwarderInstaller.
But this does not resolve the Issue completely, sometimes the Dialog still opens multiple times.
And especially, the Ctrl+Z behavior is still strange and jumps ~3 steps for me, depending on how long you click.

@N1k145
Copy link

N1k145 commented Apr 30, 2024

I created eclipse-platform/eclipse.platform.swt#1200 to report this behavior to SWT as I am able to reproduce this in a plain SWT Webkit Browser without any GLSP specifics

@planger
Copy link
Member

planger commented Apr 30, 2024

@N1k145 Thank you very much for your analysis and for opening the SWT bug! It would be great if we get that resolved. 🤞 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working eclipse help wanted Contributions are very welcome looking for sponsor Please consider sponsoring this feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes Duplicate Key Binding Triggers on WebKit N1k145/glsp-eclipse-integration
3 participants
@planger @tortmayr @N1k145