-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please allow users to easily configure sensitivity to errors/warnings (squiggles) #1791
Please allow users to easily configure sensitivity to errors/warnings (squiggles) #1791
Comments
Currently, I don't think there's a nice to way to set this since there's so many possible options, and I don't think we have a UI to go through all of them, but it should be possible to configure. For example, in a Maven project, I ensured there was a We do override some of these defaults in https://github.com/eclipse/eclipse.jdt.ls/blob/master/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/preferences/PreferenceManager.java#L124 . So it is possible to customize these options. With that said, do you have a rough idea of which errors/warnings are particularly annoying ? Maybe we could consider changing their default state. |
Hi @rgrunber , |
@fbricon , @testforstephen here's an example of a case where a global settings file would be beneficial. Also, some kind of location that lists the available options as opposed to having to reference the source javadoc. |
I have a small draft of such a feature I can post soon. It works as follows. For every error/warning message that can actually be ignored, a code action is generated called "Ignore ${message}" . If performed, it will create/append a file under
|
- Fixes redhat-developer/vscode-java#1791 - Some JDT core compiler problems can be ignored using the setting preference file, so offer a code action to do this for a given error/warning Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
- Fixes redhat-developer/vscode-java#1791 - Some JDT core compiler problems can be ignored using the setting preference file, so offer a code action to do this for a given error/warning - Add testcase Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
- Fixes redhat-developer/vscode-java#1791 - Some JDT core compiler problems can be ignored using the setting preference file, so offer a code action to do this for a given error/warning - Add testcase Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
- Fixes redhat-developer/vscode-java#1791 - Some JDT core compiler problems can be ignored using the setting preference file, so offer a code action to do this for a given error/warning - Add testcase Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
- Fixes redhat-developer/vscode-java#1791 - Some JDT core compiler problems can be ignored using the setting preference file, so offer a code action to do this for a given error/warning - Add testcase Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
- Fixes redhat-developer/vscode-java#1791 - Some JDT core compiler problems can be ignored using the setting preference file, so offer a code action to do this for a given error/warning - Code action appears only when a `java.settings.url` is detected that is on the local filesystem - Add testcase Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
- Fixes redhat-developer/vscode-java#1791 - Some JDT core compiler problems can be ignored using the setting preference file, so offer a code action to do this for a given error/warning - Code action appears only when a `java.settings.url` is detected that is on the local filesystem - Add testcase Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
Users are annoyed and distracted by a variety of error and warning indicators. (i.e. "the squiggle obfuscates the code when it applies to an entire block of code")
It's not an isolated complaint (see similar issue 1657). #1657
---------------------------------- Suggested remedies ------------------------------------------------------------------------------------------------ -
Could the yellow squiggly for warnings be removed or have the option to turn them on or off within the workspace plugin settings?
Maybe show a warning marker on the line number instead (or another option to turn on or off if people want yellow squiggly and marker on the line number)?
Or is there a lever / option to change the color of the squiggly in the workspace? Maybe make it more transparent? Possibly a theme option/setting?
Please consider these ideas, look for ways to make the Java extension even better. Thank you.
The text was updated successfully, but these errors were encountered: