-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Direct link to workspace does not work when missing trailing / #23
Labels
Comments
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
lucas-koehler
added a commit
that referenced
this issue
Dec 12, 2022
Add an NginX snippet to the instances ingress: When the URL does not request a file and does not end with a `/`, redirect to add a trailing `/`. This allows correct resolution of relative paths to resources (e.g. js, css files). Fix #23 Contributed on behalf of STMicroelectronics and CEA Signed-off-by: Lucas Koehler <lkoehler@eclipsesource.com>
lucas-koehler
added a commit
to eclipse-theia/theia-cloud-helm
that referenced
this issue
Dec 12, 2022
Add an NginX snippet to the instances ingress: When the URL does not request a file and does not end with a `/`, redirect to add a trailing `/`. This allows correct resolution of relative paths to resources (e.g. js, css files). Related to eclipse-theia/theia-cloud#23 Contributed on behalf of STMicroelectronics and CEA Signed-off-by: Lucas Koehler <lkoehler@eclipsesource.com>
lucas-koehler
added a commit
that referenced
this issue
Dec 13, 2022
Add an NginX snippet to the instances ingress: When the URL does not request a file and does not end with a `/`, redirect to add a trailing `/`. This allows correct resolution of relative paths to resources (e.g. js, css files). TODO: works without keycloak; ends in redirect loop with keycloak WillFix #23 Contributed on behalf of STMicroelectronics and CEA Signed-off-by: Lucas Koehler <lkoehler@eclipsesource.com>
lucas-koehler
added a commit
to eclipse-theia/theia-cloud-helm
that referenced
this issue
Dec 13, 2022
Add an NginX snippet to the instances ingress: When the URL does not request a file and does not end with a `/`, redirect to add a trailing `/`. This allows correct resolution of relative paths to resources (e.g. js, css files). TODO: works without keycloak; ends in redirect loop with keycloak Related to eclipse-theia/theia-cloud#23 Contributed on behalf of STMicroelectronics and CEA Signed-off-by: Lucas Koehler <lkoehler@eclipsesource.com>
Does not work the same as the redirect for landing pages because it results in a redirect loop when using keycloak |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This issue is stale because it has been open for 180 days with no activity. |
Keep open |
This issue is stale because it has been open for 180 days with no activity. |
This issue was closed because it has been inactive for 14 days since being marked as stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Landing pages may also need the trailing / to function properly.
Probably there is a way to configure the nginx ingress to make this work without /
The text was updated successfully, but these errors were encountered: