Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TM4E context menu actions should not be allowed in read-only documents #789

Open
rubenporras opened this issue Aug 23, 2024 · 0 comments
Open

Comments

@rubenporras
Copy link
Contributor

rubenporras commented Aug 23, 2024

Currently, if you open a read-only file and try to perform any of the comment actions (Toggle Line Comment, Add Block Comment, Remove Block Comment), the contents of the file will appear to change.

Note that it is not possible to save the file with these modifications.

Nevertheless, it should not be possible to apply commenting to a read-only document, even just at the UI level, if the document is read only, the menu items should be disabled, as for the delete/copy actions in the screenshot.

image-2024-08-13-15-37-13-332

Probably same problem and same pattern for the fix as in eclipse-lsp4e/lsp4e#1078

@rubenporras rubenporras changed the title TextMate context menu actions should not be allowed in read-only documents TM4E context menu actions should not be allowed in read-only documents Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant