Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Enable linting for examples and skeleton app #110

Open
doosuu opened this issue Oct 9, 2023 · 0 comments
Open

[Feature]: Enable linting for examples and skeleton app #110

doosuu opened this issue Oct 9, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@doosuu
Copy link
Member

doosuu commented Oct 9, 2023

Description

After the release of #107 linting of examples is disabled. This is because once create copies the examples into a new project structure and runs pre-commit in that new app repository, the linters (black and isort) behave differently than in the main SDK repo. To circumvent this, examples have been pre-formatted for proper layout in app repositories and linting them in the SDK has been disabled.

Suggested Solution

Investigate why linters behave differently under SDK and app repositories and fix the issue. Lastly, linting for examples shall be re-enabled in the SDK repo.

Alternatives

No response

Additional Context

No response
@doosuu doosuu added the enhancement New feature or request label Oct 9, 2023
@doosuu doosuu mentioned this issue Oct 9, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Velocitas Backlog
Status: 📋 Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@doosuu