Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Add subscribe to Node class #127

Open
Chrylo opened this issue May 28, 2024 · 0 comments
Open

[Feature]: Add subscribe to Node class #127

Chrylo opened this issue May 28, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@Chrylo
Copy link
Contributor

Chrylo commented May 28, 2024

Description

Only a DataPoint (subclass of a node) has a subscribe method. This forces the developer to force cast from Node to DataPoint when using the following API:

node: DataPoint = self.Vehicle.getNode(signal_str) # type: ignore

Originally posted by @Chrylo in #126 (comment)

Suggested Solution

  • Implement the subscribe method also for the Node class
  • If a node (which is not a DataPoint / Signal) is being subscribed too then subscribe to all children

Alternatives

No response

Additional Context

No response
@Chrylo Chrylo added the enhancement New feature or request label May 28, 2024
@Chrylo Chrylo mentioned this issue May 28, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Velocitas Backlog
Status: 🆕 New
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Chrylo