Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IMarkedIons Does not Support High Resolution MS #38

Open
kerner1000 opened this issue Sep 28, 2019 · 1 comment
Open

IMarkedIons Does not Support High Resolution MS #38

kerner1000 opened this issue Sep 28, 2019 · 1 comment
Labels
api-change Marks an issue that would most-likeley requires an API change enhancement New feature or request
Milestone

Comments

@kerner1000
Copy link
Contributor

Ions are represented as int, better double or IIon should be used.

@laeubi
Copy link
Member

laeubi commented Sep 29, 2019

IMarkedIons is only a container for IMarkedIon that support double already.

But the IMarkedIons is currently explicitly designed to only contain "integer ions". Even though I think it is possible to extend the idea of marked Ions to higher precision (e.g. specifying a desired number of digits to match, replacing getIonsNominal() with a "matches" method) we should first describe what is the use-case for this, for example why/when/where/how would a user like to describe ions in a higher resolution.

@laeubi laeubi added api-change Marks an issue that would most-likeley requires an API change enhancement New feature or request labels Oct 15, 2019
@laeubi laeubi added this to the 0.9.x milestone Mar 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-change Marks an issue that would most-likeley requires an API change enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants