New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename symbol always opens a dialog #891

Open

akurtakov opened this issue Jan 11, 2024 · 1 comment

Labels

Contributor

akurtakov commented Jan 11, 2024

It would be nice to have inline editing (note - not asking for linked editing of all references ) so there is no extra dialog opened.

Contributor

mickaelistria commented Jan 11, 2024

It would probably be even easier to enable linked editing on rename. To do so, instead of

prepareRename
showDialog for newName
call rename to get the edit
apply the edit

we can try

prepareRename
callRename with another name of same length (eg myVariable becomes xxxxxxxxx), get the edit
from the ranges returned in the edit, enable a linked edit in the editor.

sebthom added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment