Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PartialClassExtractor can handle newlines wrong #3207

Open
Boereck opened this issue Sep 26, 2024 · 2 comments
Open

PartialClassExtractor can handle newlines wrong #3207

Boereck opened this issue Sep 26, 2024 · 2 comments

Comments

@Boereck
Copy link

Boereck commented Sep 26, 2024

If the CodeConfig defines a lineDelimiter that is different than the system one, then org.eclipse.xtext.xtext.generator.parser.antlr.splitting.PartialClassExtractor fails to do extractions, because it assumes the files it works on were generated using system line breaks.

I guess a fix would be to pass the CodeConfig or the delimiter itself into the PartialClassExtractor constructor and use the delimiter instead of Strings.newLine().

@cdietrich
Copy link
Member

@szarnekow wdyt

@szarnekow
Copy link
Contributor

I'd rather support all line delimiters in the PartialClassExtractor instead of just the system's or the one passed into the ctor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants