-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/adding dart support #246
base: develop
Are you sure you want to change the base?
Feature/adding dart support #246
Conversation
I initially thought that C and N stands for Core2 and NG5 in subgridType but I then found a comment from Willem that it actually stands for centroids and edges i.e. the second commit that removes the D |
@stefaniereuter You need to sign the CLA (Contributor License Agreement) before we can proceed. |
Yes, that is correct. So the combined changes in this PR are fine. It will be probably be worth squashing them into a single commit at the point of merging it. |
Hi Sharam, sorry I had already signed it but I did not click on rechecking. For me it now says all committers signed... So I assume it worked |
The last three entries in this table should be prefixed by a string like FESOM
Note how the other names have the ORCA substring. Really this kind of naming should be the responsibility of Data Governance |
I've just contacted Data Governance. I'll create a ticket in their jira space and will let you know what they say. |
This is related to ECC-1922 , to add support for Fesom grid DART . This is relevant for intermediate climate DT runs with FESOM.