Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mistake in leva example code #5

Open
dswhy opened this issue Jun 12, 2024 · 1 comment
Open

Mistake in leva example code #5

dswhy opened this issue Jun 12, 2024 · 1 comment

Comments

@dswhy
Copy link

dswhy commented Jun 12, 2024

Hey there,

just letting you know that there is a small mistake in the leva example for the glowInternalRadius variable. In the example it looks like this:

const glowControls = useControls({
    falloff: { value: 0.45, min: 0.0, max: 1.0 },
    glowInternalRadius: { value: 0.7, min: -1.0, max: 1.0 },
    glowColor: { value: "#51a4de" },
    glowSharpness: { value: 1.0, min: 0.0, max: 2.0 },
    side: { value: "THREE.FrontSide", options: ["THREE.FrontSide", "THREE.BackSide", "THREE.DoubleSide"] },
    opacity: { value: 1.0, min: 0.0, max: 1.0 },
    depthTest: false,
});

However, it seems like glowInternalRadius is not supposed to be between -1 and 1, but rather between -10 and 10? As the default value is 6 and not 0.6.

This took me a second to notice since I was playing around with values unable to get the effect desired.

Best!

@ektogamat
Copy link
Owner

thank you very much for pointing that! I will make sure to correct this on my next release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants