Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] [PRC Milestone 3] Update API and internal rule schemas with new fields #175680

Closed
jpdjere opened this issue Jan 26, 2024 · 4 comments
Labels
Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area release_note:enhancement Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.

Comments

@jpdjere
Copy link
Contributor

jpdjere commented Jan 26, 2024

Prebuilt Rule Customization Epic - Milestone 3: #174168
Main Epic: https://github.com/elastic/security-team/issues/1974 (internal)

Additional Material:
- Milestone 3 - Software Design RFC
- Prebuilt Rules Customization Technical Design


Description:
Update our rule schemas as detailed in the Necessary rule schema changes of the software design document.

Concretely, the changes needed are:

1. In the API schema

2. In the internal rule schema


  • These changes should be backwards-compatible and should be able to be merged into main or a feature branch without making braking changes.
  • One exception: changing the immutable schema for RuleImport will change the behaviour of our app, and allow users to import prebuilt rules, which is a breaking change. So on a first phase, we can limit this change to be: only update this schema to accept the prebuilt field and leave the immutable field untouched to keep the behaviour the same. Then create as follow up another ticket to complete the migration, once we are ready to accept the importing of prebuilt rules.
@botelastic botelastic bot added the needs-team Issues missing a team label label Jan 26, 2024
@jpdjere jpdjere changed the title [Security Solution] [PRC Milestone 3] [Security Solution] [PRC Milestone 3] Update API and internal rule schemas with new fields Jan 26, 2024
@jpdjere jpdjere added release_note:enhancement Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area labels Jan 26, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management)

@jpdjere
Copy link
Contributor Author

jpdjere commented Apr 9, 2024

Closing in favour of new tickets planned: #174168 (comment)

@jpdjere jpdjere closed this as completed Apr 9, 2024
@banderror banderror closed this as not planned Won't fix, can't repro, duplicate, stale Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area release_note:enhancement Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Projects
None yet
Development

No branches or pull requests

3 participants