Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not rely on _source for cloud_security_posture plugin queries in Kibana #198642

Open
1 task
maxcold opened this issue Nov 1, 2024 · 2 comments
Open
1 task
Labels
8.18 candidate Feature:Cloud-Security Cloud Security related features Team:Cloud Security Cloud Security team related
Milestone

Comments

@maxcold
Copy link
Contributor

maxcold commented Nov 1, 2024

Motivation

While working on the AWS Security Hub integration Service Integration team pointed out a problem with the cloud_security_posture plugin relying on querying _source in Kibana, eg. for data grid queries. It has at least two consequences:

  • in integrations, it's common to remove constant_keyword fields from the _source to optimize storage. As a result we don't have this data in our data gird. It happened with observer.vendor for example.
  • in serverless and in ESS 9.0 querying _source has a performance penalty due to the need to recreate the _source from the fields.

We need to stop relying on the _source field for queries and use the fields directly

Definition of done

  • _source field is not queried in Kibana plugin cloud_security_posture

Out of scope

Related tasks/epics

Team tag

@elastic/kibana-cloud-security-posture

@maxcold maxcold added the v9.0.0 label Nov 1, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Nov 1, 2024
@maxcold maxcold added 8.18 candidate and removed v9.0.0 needs-team Issues missing a team label labels Nov 1, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Nov 1, 2024
@maxcold maxcold added Team:Cloud Security Cloud Security team related Feature:Cloud-Security Cloud Security related features 8.18 candidate and removed needs-team Issues missing a team label 8.18 candidate labels Nov 1, 2024
@seanrathier seanrathier changed the title Do not rely on _source for queries in Kibana Do not rely on _source for cloud_security_posture plugin queries in Kibana Nov 5, 2024
@seanrathier seanrathier self-assigned this Nov 5, 2024
@seanrathier seanrathier changed the title Do not rely on _source for cloud_security_posture plugin queries in Kibana [Cloud Security] Do not rely on _source for cloud_security_posture plugin queries in Kibana Nov 5, 2024
@acorretti acorretti changed the title [Cloud Security] Do not rely on _source for cloud_security_posture plugin queries in Kibana Do not rely on _source for cloud_security_posture plugin queries in Kibana Nov 20, 2024
@maxcold
Copy link
Contributor Author

maxcold commented Nov 22, 2024

More context on why this is still important even if not required for 9.0 in here https://github.com/elastic/security-team/issues/10427#issuecomment-2468680312

@andrewkroh
Copy link
Member

@maxcold FYI, the workaround that we did in the AWS integration (elastic/integrations#11608 (comment)) to always incorporate the constant_keyword value into _source will not solve the problem under LogsDB. This is because in synthesized _source, constant_keyword fields are never incorporated into the value. The values can only be accessed through fields. Relates to elastic/elasticsearch#117182.

@maxcold maxcold added this to the 9.0 milestone Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.18 candidate Feature:Cloud-Security Cloud Security related features Team:Cloud Security Cloud Security team related
Projects
None yet
Development

No branches or pull requests

3 participants