Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sustainable Kibana Architecture: Move modules owned by @elastic/security-scalability #202849

Conversation

gsoldevila
Copy link
Contributor

@gsoldevila gsoldevila commented Dec 4, 2024

Summary

This PR aims at relocating some of the Kibana modules (plugins and packages) into a new folder structure, according to the Sustainable Kibana Architecture initiative.

Important

  • We kindly ask you to:
    • Manually fix the errors in the error section below (if there are any).
    • Search for the packages[\/\\] and plugins[\/\\] patterns in the source code (Babel and Eslint config files), and update them appropriately.
    • Manually review .buildkite/scripts/pipelines/pull_request/pipeline.ts to ensure that any CI pipeline customizations continue to be correctly applied after the changed path names
    • Review all of the updated files, specially the .ts and .js files listed in the sections below, as some of them contain relative paths that have been updated.
    • Think of potential impact of the move, including tooling and configuration files that can be pointing to the relocated modules. E.g.:
      • customised eslint rules
      • docs pointing to source code

Note

This PR has been auto-generated.
Do not attempt to push any changes unless you know what you are doing.
Please use #sustainable_kibana_architecture Slack channel for feedback.

1 plugin(s) are going to be relocated:

Id Target folder
@kbn/integration-assistant-plugin x-pack/platform/plugins/shared/integration_assistant
Updated references
./.eslintrc.js
./docs/developer/plugin-list.asciidoc
./package.json
./packages/kbn-repo-packages/package-map.json
./packages/kbn-ts-projects/config-paths.json
./tsconfig.base.json
./x-pack/.i18nrc.json
./x-pack/platform/plugins/shared/integration_assistant/README.md
./x-pack/platform/plugins/shared/integration_assistant/jest.config.js
./x-pack/platform/plugins/shared/integration_assistant/server/config.ts
./yarn.lock
Updated relative paths
x-pack/platform/plugins/shared/integration_assistant/jest.config.js:10
x-pack/platform/plugins/shared/integration_assistant/scripts/draw_graphs.js:8
x-pack/platform/plugins/shared/integration_assistant/tsconfig.json:13
x-pack/platform/plugins/shared/integration_assistant/tsconfig.json:2
Script errors

Copy link
Contributor

github-actions bot commented Dec 4, 2024

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@gsoldevila gsoldevila added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:Security-Scalability Team label for Security Integrations Scalability Team labels Dec 4, 2024
@gsoldevila gsoldevila marked this pull request as ready for review December 4, 2024 08:23
@gsoldevila gsoldevila requested review from a team as code owners December 4, 2024 08:23
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-scalability (Team:Security-Scalability)

@bhapas
Copy link
Contributor

bhapas commented Dec 5, 2024

@gsoldevila
How soon do we need to do this? My only worry is about backporting fixes after this change is pretty much manual , right? Not sure if backporting tool handles backporting the changes to branches before sustainable arch?

@gsoldevila
Copy link
Contributor Author

@gsoldevila How soon do we need to do this? My only worry is about backporting fixes after this change is pretty much manual , right? Not sure if backporting tool handles backporting the changes to branches before sustainable arch?

I'm gonna start a wave of relocation PRs against 8.x (in parallel, hence backport:skip here).
The goal is to have both branches updated, so that backporting is not a pain.
Thus, we need these reviewed / approved / merged ASAP.

@gsoldevila gsoldevila force-pushed the kbn-team-1309-move-kibana-security-scalability branch from 3179bfc to 1e30f62 Compare December 5, 2024 15:48
@bhapas
Copy link
Contributor

bhapas commented Dec 10, 2024

@gsoldevila Can this branch be rebased?

@gsoldevila gsoldevila force-pushed the kbn-team-1309-move-kibana-security-scalability branch from 8782803 to de10b75 Compare December 10, 2024 14:37
@ebeahan ebeahan force-pushed the kbn-team-1309-move-kibana-security-scalability branch from c41df61 to 853c47d Compare December 12, 2024 21:04
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

@gsoldevila gsoldevila added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) and removed backport:skip This commit does not require backporting labels Dec 13, 2024
@gsoldevila gsoldevila merged commit 6bf5e68 into elastic:main Dec 13, 2024
11 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12313889135

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.x Backport failed because of merge conflicts

You might need to backport the following PRs to 8.x:
- [Synthetics] migrate first set of tests (#198950)
- [Obs UX Management] Migrate leftover code owner !! (#203814)
- Sustainable Kibana Architecture: Add scripts/relocate CLI (beta) (#203803)
- [UA] kibana-core ownership (#203410)
- [Security Solution] - Update codeowners (#202046)

Manual backport

To create the backport manually run:

node scripts/backport --pr 202849

Questions ?

Please refer to the Backport tool documentation

gsoldevila added a commit to gsoldevila/kibana that referenced this pull request Dec 13, 2024
…rity-scalability` (elastic#202849)

## Summary

This PR aims at relocating some of the Kibana modules (plugins and
packages) into a new folder structure, according to the _Sustainable
Kibana Architecture_ initiative.

> [!IMPORTANT]
> * We kindly ask you to:
> * Manually fix the errors in the error section below (if there are
any).
> * Search for the `packages[\/\\]` and `plugins[\/\\]` patterns in the
source code (Babel and Eslint config files), and update them
appropriately.
> * Manually review
`.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that
any CI pipeline customizations continue to be correctly applied after
the changed path names
> * Review all of the updated files, specially the `.ts` and `.js` files
listed in the sections below, as some of them contain relative paths
that have been updated.
> * Think of potential impact of the move, including tooling and
configuration files that can be pointing to the relocated modules. E.g.:
>     * customised eslint rules
>     * docs pointing to source code

> [!NOTE]
> This PR has been auto-generated.
> Do not attempt to push any changes unless you know what you are doing.
> Please use
[#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E)
Slack channel for feedback.

#### 1 plugin(s) are going to be relocated:

| Id | Target folder |
| -- | ------------- |
| `@kbn/integration-assistant-plugin` |
`x-pack/platform/plugins/shared/integration_assistant` |

<details>
<summary>Updated references</summary>

```
./.eslintrc.js
./docs/developer/plugin-list.asciidoc
./package.json
./packages/kbn-repo-packages/package-map.json
./packages/kbn-ts-projects/config-paths.json
./tsconfig.base.json
./x-pack/.i18nrc.json
./x-pack/platform/plugins/shared/integration_assistant/README.md
./x-pack/platform/plugins/shared/integration_assistant/jest.config.js
./x-pack/platform/plugins/shared/integration_assistant/server/config.ts
./yarn.lock
```
</details>
<details>
<summary>Updated relative paths</summary>

```
x-pack/platform/plugins/shared/integration_assistant/jest.config.js:10
x-pack/platform/plugins/shared/integration_assistant/scripts/draw_graphs.js:8
x-pack/platform/plugins/shared/integration_assistant/tsconfig.json:13
x-pack/platform/plugins/shared/integration_assistant/tsconfig.json:2
```
</details>
<details>
<summary>Script errors</summary>

```

```
</details>

---------

Co-authored-by: Eric Beahan <eric.beahan@elastic.co>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 6bf5e68)

# Conflicts:
#	.github/CODEOWNERS
#	x-pack/platform/plugins/shared/integration_assistant/server/templates/readme.njk
@gsoldevila
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

gsoldevila added a commit that referenced this pull request Dec 13, 2024
…c/security-scalability` (#202849) (#204217)

# Backport

This will backport the following commits from `main` to `8.x`:
- [Sustainable Kibana Architecture: Move modules owned by
`@elastic/security-scalability`
(#202849)](#202849)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Gerard
Soldevila","email":"gerard.soldevila@elastic.co"},"sourceCommit":{"committedDate":"2024-12-13T10:24:39Z","message":"Sustainable
Kibana Architecture: Move modules owned by
`@elastic/security-scalability` (#202849)\n\n## Summary\n\nThis PR aims
at relocating some of the Kibana modules (plugins and\npackages) into a
new folder structure, according to the _Sustainable\nKibana
Architecture_ initiative.\n\n> [!IMPORTANT]\n> * We kindly ask you
to:\n> * Manually fix the errors in the error section below (if there
are\nany).\n> * Search for the `packages[\\/\\\\]` and
`plugins[\\/\\\\]` patterns in the\nsource code (Babel and Eslint config
files), and update them\nappropriately.\n> * Manually
review\n`.buildkite/scripts/pipelines/pull_request/pipeline.ts` to
ensure that\nany CI pipeline customizations continue to be correctly
applied after\nthe changed path names\n> * Review all of the updated
files, specially the `.ts` and `.js` files\nlisted in the sections
below, as some of them contain relative paths\nthat have been
updated.\n> * Think of potential impact of the move, including tooling
and\nconfiguration files that can be pointing to the relocated modules.
E.g.:\n> * customised eslint rules\n> * docs pointing to source
code\n\n> [!NOTE]\n> This PR has been auto-generated.\n> Do not attempt
to push any changes unless you know what you are doing.\n> Please
use\n[#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E)\nSlack
channel for feedback.\n\n\n\n\n#### 1 plugin(s) are going to be
relocated:\n\n| Id | Target folder |\n| -- | ------------- |\n|
`@kbn/integration-assistant-plugin`
|\n`x-pack/platform/plugins/shared/integration_assistant`
|\n\n\n<details>\n<summary>Updated
references</summary>\n\n```\n./.eslintrc.js\n./docs/developer/plugin-list.asciidoc\n./package.json\n./packages/kbn-repo-packages/package-map.json\n./packages/kbn-ts-projects/config-paths.json\n./tsconfig.base.json\n./x-pack/.i18nrc.json\n./x-pack/platform/plugins/shared/integration_assistant/README.md\n./x-pack/platform/plugins/shared/integration_assistant/jest.config.js\n./x-pack/platform/plugins/shared/integration_assistant/server/config.ts\n./yarn.lock\n```\n</details>\n<details>\n<summary>Updated
relative
paths</summary>\n\n```\nx-pack/platform/plugins/shared/integration_assistant/jest.config.js:10\nx-pack/platform/plugins/shared/integration_assistant/scripts/draw_graphs.js:8\nx-pack/platform/plugins/shared/integration_assistant/tsconfig.json:13\nx-pack/platform/plugins/shared/integration_assistant/tsconfig.json:2\n```\n</details>\n<details>\n<summary>Script
errors</summary>\n\n```\n\n```\n</details>\n\n---------\n\nCo-authored-by:
Eric Beahan <eric.beahan@elastic.co>\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"6bf5e68e06bf60df0075d6d60f57a836a1d49fc8","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","v9.0.0","backport:prev-minor","Team:Security-Scalability"],"number":202849,"url":"https://github.com/elastic/kibana/pull/202849","mergeCommit":{"message":"Sustainable
Kibana Architecture: Move modules owned by
`@elastic/security-scalability` (#202849)\n\n## Summary\n\nThis PR aims
at relocating some of the Kibana modules (plugins and\npackages) into a
new folder structure, according to the _Sustainable\nKibana
Architecture_ initiative.\n\n> [!IMPORTANT]\n> * We kindly ask you
to:\n> * Manually fix the errors in the error section below (if there
are\nany).\n> * Search for the `packages[\\/\\\\]` and
`plugins[\\/\\\\]` patterns in the\nsource code (Babel and Eslint config
files), and update them\nappropriately.\n> * Manually
review\n`.buildkite/scripts/pipelines/pull_request/pipeline.ts` to
ensure that\nany CI pipeline customizations continue to be correctly
applied after\nthe changed path names\n> * Review all of the updated
files, specially the `.ts` and `.js` files\nlisted in the sections
below, as some of them contain relative paths\nthat have been
updated.\n> * Think of potential impact of the move, including tooling
and\nconfiguration files that can be pointing to the relocated modules.
E.g.:\n> * customised eslint rules\n> * docs pointing to source
code\n\n> [!NOTE]\n> This PR has been auto-generated.\n> Do not attempt
to push any changes unless you know what you are doing.\n> Please
use\n[#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E)\nSlack
channel for feedback.\n\n\n\n\n#### 1 plugin(s) are going to be
relocated:\n\n| Id | Target folder |\n| -- | ------------- |\n|
`@kbn/integration-assistant-plugin`
|\n`x-pack/platform/plugins/shared/integration_assistant`
|\n\n\n<details>\n<summary>Updated
references</summary>\n\n```\n./.eslintrc.js\n./docs/developer/plugin-list.asciidoc\n./package.json\n./packages/kbn-repo-packages/package-map.json\n./packages/kbn-ts-projects/config-paths.json\n./tsconfig.base.json\n./x-pack/.i18nrc.json\n./x-pack/platform/plugins/shared/integration_assistant/README.md\n./x-pack/platform/plugins/shared/integration_assistant/jest.config.js\n./x-pack/platform/plugins/shared/integration_assistant/server/config.ts\n./yarn.lock\n```\n</details>\n<details>\n<summary>Updated
relative
paths</summary>\n\n```\nx-pack/platform/plugins/shared/integration_assistant/jest.config.js:10\nx-pack/platform/plugins/shared/integration_assistant/scripts/draw_graphs.js:8\nx-pack/platform/plugins/shared/integration_assistant/tsconfig.json:13\nx-pack/platform/plugins/shared/integration_assistant/tsconfig.json:2\n```\n</details>\n<details>\n<summary>Script
errors</summary>\n\n```\n\n```\n</details>\n\n---------\n\nCo-authored-by:
Eric Beahan <eric.beahan@elastic.co>\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"6bf5e68e06bf60df0075d6d60f57a836a1d49fc8"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202849","number":202849,"mergeCommit":{"message":"Sustainable
Kibana Architecture: Move modules owned by
`@elastic/security-scalability` (#202849)\n\n## Summary\n\nThis PR aims
at relocating some of the Kibana modules (plugins and\npackages) into a
new folder structure, according to the _Sustainable\nKibana
Architecture_ initiative.\n\n> [!IMPORTANT]\n> * We kindly ask you
to:\n> * Manually fix the errors in the error section below (if there
are\nany).\n> * Search for the `packages[\\/\\\\]` and
`plugins[\\/\\\\]` patterns in the\nsource code (Babel and Eslint config
files), and update them\nappropriately.\n> * Manually
review\n`.buildkite/scripts/pipelines/pull_request/pipeline.ts` to
ensure that\nany CI pipeline customizations continue to be correctly
applied after\nthe changed path names\n> * Review all of the updated
files, specially the `.ts` and `.js` files\nlisted in the sections
below, as some of them contain relative paths\nthat have been
updated.\n> * Think of potential impact of the move, including tooling
and\nconfiguration files that can be pointing to the relocated modules.
E.g.:\n> * customised eslint rules\n> * docs pointing to source
code\n\n> [!NOTE]\n> This PR has been auto-generated.\n> Do not attempt
to push any changes unless you know what you are doing.\n> Please
use\n[#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E)\nSlack
channel for feedback.\n\n\n\n\n#### 1 plugin(s) are going to be
relocated:\n\n| Id | Target folder |\n| -- | ------------- |\n|
`@kbn/integration-assistant-plugin`
|\n`x-pack/platform/plugins/shared/integration_assistant`
|\n\n\n<details>\n<summary>Updated
references</summary>\n\n```\n./.eslintrc.js\n./docs/developer/plugin-list.asciidoc\n./package.json\n./packages/kbn-repo-packages/package-map.json\n./packages/kbn-ts-projects/config-paths.json\n./tsconfig.base.json\n./x-pack/.i18nrc.json\n./x-pack/platform/plugins/shared/integration_assistant/README.md\n./x-pack/platform/plugins/shared/integration_assistant/jest.config.js\n./x-pack/platform/plugins/shared/integration_assistant/server/config.ts\n./yarn.lock\n```\n</details>\n<details>\n<summary>Updated
relative
paths</summary>\n\n```\nx-pack/platform/plugins/shared/integration_assistant/jest.config.js:10\nx-pack/platform/plugins/shared/integration_assistant/scripts/draw_graphs.js:8\nx-pack/platform/plugins/shared/integration_assistant/tsconfig.json:13\nx-pack/platform/plugins/shared/integration_assistant/tsconfig.json:2\n```\n</details>\n<details>\n<summary>Script
errors</summary>\n\n```\n\n```\n</details>\n\n---------\n\nCo-authored-by:
Eric Beahan <eric.beahan@elastic.co>\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"6bf5e68e06bf60df0075d6d60f57a836a1d49fc8"}}]}]
BACKPORT-->
@rudolf rudolf added the plugin groups Relocate all plugins and packages under their respective platform/solution groups label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) plugin groups Relocate all plugins and packages under their respective platform/solution groups release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Security-Scalability Team label for Security Integrations Scalability Team v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants