-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FAILED - DISREGARD] Sustainable Kibana Architecture: Move modules owned by @elastic/security-threat-hunting
#202859
Conversation
Pinging @elastic/kibana-core (Team:Core) |
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
💚 Build Succeeded
Metrics [docs]
|
.eslintrc.js
Outdated
@@ -1313,7 +1313,7 @@ module.exports = { | |||
'x-pack/plugins/security_solution_serverless/**/*.{js,mjs,ts,tsx}', | |||
'x-pack/plugins/cases/**/*.{js,mjs,ts,tsx}', | |||
'x-pack/plugins/ecs_data_quality_dashboard/**/*.{js,mjs,ts,tsx}', | |||
'x-pack/packages/kbn-data-stream-adapter/**/*.{js,mjs,ts,tsx}', | |||
'x-pack/x-pack/solutions/security/packages/kbn-data-stream-adapter/**/*.{js,mjs,ts,tsx}', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is there a nested x-pack?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error in my relocation script, will re-run to auto fix. Sorry about that
@gsoldevila - Although security created this adapter, the hope was that this would become a shared platform level utility. What is the process for starting those discussions and moving this into the platform? Thanks! |
caef4e6
to
1ab7d42
Compare
Please refer to #sustaninable-kibana-architecture Slack channel, thanks! |
@elastic/security-threat-hunting
@elastic/security-threat-hunting
@michaelolo24 this PR has been replaced by #203046, sorry for the inconvenience. |
Summary
This PR aims at relocating some of the Kibana modules (plugins and packages) into a new folder structure, according to the Sustainable Kibana Architecture initiative.
Important
packages[\/\\]
andplugins[\/\\]
patterns in the source code (Babel and Eslint config files), and update them appropriately..buildkite/scripts/pipelines/pull_request/pipeline.ts
to ensure that any CI pipeline customizations continue to be correctly applied after the changed path names.ts
and.js
files listed in the sections below, as some of them contain relative paths that have been updated.Note
This PR has been auto-generated.
Do not attempt to push any changes unless you know what you are doing.
Please use #sustainable_kibana_architecture Slack channel for feedback.
2 package(s) are going to be relocated:
@kbn/data-stream-adapter
x-pack/solutions/security/packages/kbn-data-stream-adapter
@kbn/index-adapter
x-pack/solutions/security/packages/kbn-index-adapter
Updated references
Updated relative paths
Script errors