Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kbn-test] extract ES logs only for svl #202927

Merged
merged 1 commit into from
Dec 4, 2024
Merged

[kbn-test] extract ES logs only for svl #202927

merged 1 commit into from
Dec 4, 2024

Conversation

dmlemeshko
Copy link
Member

@dmlemeshko dmlemeshko commented Dec 4, 2024 •
edited by kibanamachine
Loading

Summary

PR fixes the issue reported by @dolaru when running stateful FTR environment without docker setup locally:

 info [es] killing node
 info [es] stopping node scout
 info [es] no debug files found, assuming es did not write any
 info [es] cleanup complete
ERROR UNHANDLED ERROR
ERROR Error: Command failed with exit code 1: docker ps -a --format {{.Names}}
      error during connect: Get "http://docker.example.com/v1.47/containers/json?all=1": command [ssh -o ConnectTimeout=30 -T -l dolaru -- debian-12-vm docker system dial-stdio] has exited with exit status 255, make sure the URL is valid, and Docker 18.09 or later is installed on the remote host: stderr=ssh: Could not resolve hostname dolaru-m2-mbp-debian.local: nodename nor servname provided, or not known
          at makeError (/Users/dolaru/workspace/kibana/node_modules/execa/lib/error.js:60:11)
          at handlePromise (/Users/dolaru/workspace/kibana/node_modules/execa/index.js:118:26)
          at processTicksAndRejections (node:internal/process/task_queues:95:5)
          at extractAndArchiveLogs (extract_and_archive_logs.ts:34:41)
          at run_elasticsearch.ts:86:5

Since we don't need it for stateful ES instance, I added condition. kbn-scout had the same issue, so I exported cleanupElasticsearch from kbn-test to avoid code duplication

@dmlemeshko dmlemeshko requested a review from dolaru December 4, 2024 13:59
@dmlemeshko dmlemeshko self-assigned this Dec 4, 2024
@dmlemeshko dmlemeshko added release_note:skip Skip the PR/issue when compiling release notes v9.0.0 backport:version Backport to applied version labels v8.17.0 labels Dec 4, 2024
dolaru
dolaru approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@dolaru dolaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #72 / EQL execution logic API @ess @serverless Alert Suppression for EQL rules @skipInServerless sequence queries with suppression duration does not suppress alerts outside of duration

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/test 298 303 +5
Unknown metric groups

API count

id before after diff
@kbn/test 353 358 +5

cc @dmlemeshko

@dmlemeshko dmlemeshko marked this pull request as ready for review December 4, 2024 16:58
@dmlemeshko dmlemeshko requested review from a team as code owners December 4, 2024 16:58
@dmlemeshko dmlemeshko merged commit cdb5a2d into elastic:main Dec 4, 2024
18 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.17

https://github.com/elastic/kibana/actions/runs/12170066479

@dmlemeshko dmlemeshko added v8.18.0 and removed v8.17.0 labels Dec 4, 2024
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.17 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 202927

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Dec 5, 2024
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 202927 locally

1 similar comment
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 202927 locally

SoniaSanzV pushed a commit to SoniaSanzV/kibana that referenced this pull request Dec 9, 2024
@dmlemeshko @SoniaSanzV
[kbn-test] extract ES logs only for svl (elastic#202927)
4e62c7d 
## Summary

PR fixes the issue reported by @dolaru when running stateful FTR
environment without docker setup locally:

```
 info [es] killing node
 info [es] stopping node scout
 info [es] no debug files found, assuming es did not write any
 info [es] cleanup complete
ERROR UNHANDLED ERROR
ERROR Error: Command failed with exit code 1: docker ps -a --format {{.Names}}
      error during connect: Get "http://docker.example.com/v1.47/containers/json?all=1": command [ssh -o ConnectTimeout=30 -T -l dolaru -- debian-12-vm docker system dial-stdio] has exited with exit status 255, make sure the URL is valid, and Docker 18.09 or later is installed on the remote host: stderr=ssh: Could not resolve hostname dolaru-m2-mbp-debian.local: nodename nor servname provided, or not known
          at makeError (/Users/dolaru/workspace/kibana/node_modules/execa/lib/error.js:60:11)
          at handlePromise (/Users/dolaru/workspace/kibana/node_modules/execa/index.js:118:26)
          at processTicksAndRejections (node:internal/process/task_queues:95:5)
          at extractAndArchiveLogs (extract_and_archive_logs.ts:34:41)
          at run_elasticsearch.ts:86:5
```

Since we don't need it for stateful ES instance, I added condition.
kbn-scout had the same issue, so I exported `cleanupElasticsearch` from
`kbn-test` to avoid code duplication
SoniaSanzV pushed a commit to SoniaSanzV/kibana that referenced this pull request Dec 9, 2024
@dmlemeshko @SoniaSanzV
[kbn-test] extract ES logs only for svl (elastic#202927)
ed3fab6 
## Summary

PR fixes the issue reported by @dolaru when running stateful FTR
environment without docker setup locally:

```
 info [es] killing node
 info [es] stopping node scout
 info [es] no debug files found, assuming es did not write any
 info [es] cleanup complete
ERROR UNHANDLED ERROR
ERROR Error: Command failed with exit code 1: docker ps -a --format {{.Names}}
      error during connect: Get "http://docker.example.com/v1.47/containers/json?all=1": command [ssh -o ConnectTimeout=30 -T -l dolaru -- debian-12-vm docker system dial-stdio] has exited with exit status 255, make sure the URL is valid, and Docker 18.09 or later is installed on the remote host: stderr=ssh: Could not resolve hostname dolaru-m2-mbp-debian.local: nodename nor servname provided, or not known
          at makeError (/Users/dolaru/workspace/kibana/node_modules/execa/lib/error.js:60:11)
          at handlePromise (/Users/dolaru/workspace/kibana/node_modules/execa/index.js:118:26)
          at processTicksAndRejections (node:internal/process/task_queues:95:5)
          at extractAndArchiveLogs (extract_and_archive_logs.ts:34:41)
          at run_elasticsearch.ts:86:5
```

Since we don't need it for stateful ES instance, I added condition.
kbn-scout had the same issue, so I exported `cleanupElasticsearch` from
`kbn-test` to avoid code duplication
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 9, 2024
@dmlemeshko @CAWilson94
[kbn-test] extract ES logs only for svl (elastic#202927)
e2ef501 
## Summary

PR fixes the issue reported by @dolaru when running stateful FTR
environment without docker setup locally:

```
 info [es] killing node
 info [es] stopping node scout
 info [es] no debug files found, assuming es did not write any
 info [es] cleanup complete
ERROR UNHANDLED ERROR
ERROR Error: Command failed with exit code 1: docker ps -a --format {{.Names}}
      error during connect: Get "http://docker.example.com/v1.47/containers/json?all=1": command [ssh -o ConnectTimeout=30 -T -l dolaru -- debian-12-vm docker system dial-stdio] has exited with exit status 255, make sure the URL is valid, and Docker 18.09 or later is installed on the remote host: stderr=ssh: Could not resolve hostname dolaru-m2-mbp-debian.local: nodename nor servname provided, or not known
          at makeError (/Users/dolaru/workspace/kibana/node_modules/execa/lib/error.js:60:11)
          at handlePromise (/Users/dolaru/workspace/kibana/node_modules/execa/index.js:118:26)
          at processTicksAndRejections (node:internal/process/task_queues:95:5)
          at extractAndArchiveLogs (extract_and_archive_logs.ts:34:41)
          at run_elasticsearch.ts:86:5
```

Since we don't need it for stateful ES instance, I added condition.
kbn-scout had the same issue, so I exported `cleanupElasticsearch` from
`kbn-test` to avoid code duplication
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 202927 locally

Samiul-TheSoccerFan pushed a commit to Samiul-TheSoccerFan/kibana that referenced this pull request Dec 10, 2024
@dmlemeshko @Samiul-TheSoccerFan
[kbn-test] extract ES logs only for svl (elastic#202927)
cb8a2a3 
## Summary

PR fixes the issue reported by @dolaru when running stateful FTR
environment without docker setup locally:

```
 info [es] killing node
 info [es] stopping node scout
 info [es] no debug files found, assuming es did not write any
 info [es] cleanup complete
ERROR UNHANDLED ERROR
ERROR Error: Command failed with exit code 1: docker ps -a --format {{.Names}}
      error during connect: Get "http://docker.example.com/v1.47/containers/json?all=1": command [ssh -o ConnectTimeout=30 -T -l dolaru -- debian-12-vm docker system dial-stdio] has exited with exit status 255, make sure the URL is valid, and Docker 18.09 or later is installed on the remote host: stderr=ssh: Could not resolve hostname dolaru-m2-mbp-debian.local: nodename nor servname provided, or not known
          at makeError (/Users/dolaru/workspace/kibana/node_modules/execa/lib/error.js:60:11)
          at handlePromise (/Users/dolaru/workspace/kibana/node_modules/execa/index.js:118:26)
          at processTicksAndRejections (node:internal/process/task_queues:95:5)
          at extractAndArchiveLogs (extract_and_archive_logs.ts:34:41)
          at run_elasticsearch.ts:86:5
```

Since we don't need it for stateful ES instance, I added condition.
kbn-scout had the same issue, so I exported `cleanupElasticsearch` from
`kbn-test` to avoid code duplication
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 202927 locally

1 similar comment
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 202927 locally

CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
@dmlemeshko @CAWilson94
[kbn-test] extract ES logs only for svl (elastic#202927)
7973e76 
## Summary

PR fixes the issue reported by @dolaru when running stateful FTR
environment without docker setup locally:

```
 info [es] killing node
 info [es] stopping node scout
 info [es] no debug files found, assuming es did not write any
 info [es] cleanup complete
ERROR UNHANDLED ERROR
ERROR Error: Command failed with exit code 1: docker ps -a --format {{.Names}}
      error during connect: Get "http://docker.example.com/v1.47/containers/json?all=1": command [ssh -o ConnectTimeout=30 -T -l dolaru -- debian-12-vm docker system dial-stdio] has exited with exit status 255, make sure the URL is valid, and Docker 18.09 or later is installed on the remote host: stderr=ssh: Could not resolve hostname dolaru-m2-mbp-debian.local: nodename nor servname provided, or not known
          at makeError (/Users/dolaru/workspace/kibana/node_modules/execa/lib/error.js:60:11)
          at handlePromise (/Users/dolaru/workspace/kibana/node_modules/execa/index.js:118:26)
          at processTicksAndRejections (node:internal/process/task_queues:95:5)
          at extractAndArchiveLogs (extract_and_archive_logs.ts:34:41)
          at run_elasticsearch.ts:86:5
```

Since we don't need it for stateful ES instance, I added condition.
kbn-scout had the same issue, so I exported `cleanupElasticsearch` from
`kbn-test` to avoid code duplication
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 202927 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 202927 locally

2 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 202927 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 202927 locally

dmlemeshko added a commit to dmlemeshko/kibana that referenced this pull request Dec 18, 2024
@dmlemeshko
[kbn-test] extract ES logs only for svl (elastic#202927)
e50c575 
## Summary

PR fixes the issue reported by @dolaru when running stateful FTR
environment without docker setup locally:

```
 info [es] killing node
 info [es] stopping node scout
 info [es] no debug files found, assuming es did not write any
 info [es] cleanup complete
ERROR UNHANDLED ERROR
ERROR Error: Command failed with exit code 1: docker ps -a --format {{.Names}}
      error during connect: Get "http://docker.example.com/v1.47/containers/json?all=1": command [ssh -o ConnectTimeout=30 -T -l dolaru -- debian-12-vm docker system dial-stdio] has exited with exit status 255, make sure the URL is valid, and Docker 18.09 or later is installed on the remote host: stderr=ssh: Could not resolve hostname dolaru-m2-mbp-debian.local: nodename nor servname provided, or not known
          at makeError (/Users/dolaru/workspace/kibana/node_modules/execa/lib/error.js:60:11)
          at handlePromise (/Users/dolaru/workspace/kibana/node_modules/execa/index.js:118:26)
          at processTicksAndRejections (node:internal/process/task_queues:95:5)
          at extractAndArchiveLogs (extract_and_archive_logs.ts:34:41)
          at run_elasticsearch.ts:86:5
```

Since we don't need it for stateful ES instance, I added condition.
kbn-scout had the same issue, so I exported `cleanupElasticsearch` from
`kbn-test` to avoid code duplication

(cherry picked from commit cdb5a2d)
@dmlemeshko dmlemeshko mentioned this pull request Dec 18, 2024
Merged
@dmlemeshko
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

dmlemeshko added a commit that referenced this pull request Dec 18, 2024
@dmlemeshko
[8.x] [kbn-test] extract ES logs only for svl (#202927) (#204750)
91aa821 
# Backport

This will backport the following commits from `main` to `8.x`:
- [[kbn-test] extract ES logs only for svl
(#202927)](#202927)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dzmitry
Lemechko","email":"dzmitry.lemechko@elastic.co"},"sourceCommit":{"committedDate":"2024-12-04T23:19:41Z","message":"[kbn-test]
extract ES logs only for svl (#202927)\n\n## Summary\r\n\r\nPR fixes the
issue reported by @dolaru when running stateful FTR\r\nenvironment
without docker setup locally:\r\n\r\n```\r\n info [es] killing node\r\n
info [es] stopping node scout\r\n info [es] no debug files found,
assuming es did not write any\r\n info [es] cleanup complete\r\nERROR
UNHANDLED ERROR\r\nERROR Error: Command failed with exit code 1: docker
ps -a --format {{.Names}}\r\n error during connect: Get
\"http://docker.example.com/v1.47/containers/json?all=1\": command [ssh
-o ConnectTimeout=30 -T -l dolaru -- debian-12-vm docker system
dial-stdio] has exited with exit status 255, make sure the URL is valid,
and Docker 18.09 or later is installed on the remote host: stderr=ssh:
Could not resolve hostname dolaru-m2-mbp-debian.local: nodename nor
servname provided, or not known\r\n at makeError
(/Users/dolaru/workspace/kibana/node_modules/execa/lib/error.js:60:11)\r\n
at handlePromise
(/Users/dolaru/workspace/kibana/node_modules/execa/index.js:118:26)\r\n
at processTicksAndRejections
(node:internal/process/task_queues:95:5)\r\n at extractAndArchiveLogs
(extract_and_archive_logs.ts:34:41)\r\n at
run_elasticsearch.ts:86:5\r\n```\r\n\r\nSince we don't need it for
stateful ES instance, I added condition.\r\nkbn-scout had the same
issue, so I exported `cleanupElasticsearch` from\r\n`kbn-test` to avoid
code
duplication","sha":"cdb5a2dca2f42edbe2be47c970423d7dbd1ce99e","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport
missing","v9.0.0","backport:version","v8.18.0"],"number":202927,"url":"https://github.com/elastic/kibana/pull/202927","mergeCommit":{"message":"[kbn-test]
extract ES logs only for svl (#202927)\n\n## Summary\r\n\r\nPR fixes the
issue reported by @dolaru when running stateful FTR\r\nenvironment
without docker setup locally:\r\n\r\n```\r\n info [es] killing node\r\n
info [es] stopping node scout\r\n info [es] no debug files found,
assuming es did not write any\r\n info [es] cleanup complete\r\nERROR
UNHANDLED ERROR\r\nERROR Error: Command failed with exit code 1: docker
ps -a --format {{.Names}}\r\n error during connect: Get
\"http://docker.example.com/v1.47/containers/json?all=1\": command [ssh
-o ConnectTimeout=30 -T -l dolaru -- debian-12-vm docker system
dial-stdio] has exited with exit status 255, make sure the URL is valid,
and Docker 18.09 or later is installed on the remote host: stderr=ssh:
Could not resolve hostname dolaru-m2-mbp-debian.local: nodename nor
servname provided, or not known\r\n at makeError
(/Users/dolaru/workspace/kibana/node_modules/execa/lib/error.js:60:11)\r\n
at handlePromise
(/Users/dolaru/workspace/kibana/node_modules/execa/index.js:118:26)\r\n
at processTicksAndRejections
(node:internal/process/task_queues:95:5)\r\n at extractAndArchiveLogs
(extract_and_archive_logs.ts:34:41)\r\n at
run_elasticsearch.ts:86:5\r\n```\r\n\r\nSince we don't need it for
stateful ES instance, I added condition.\r\nkbn-scout had the same
issue, so I exported `cleanupElasticsearch` from\r\n`kbn-test` to avoid
code
duplication","sha":"cdb5a2dca2f42edbe2be47c970423d7dbd1ce99e"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202927","number":202927,"mergeCommit":{"message":"[kbn-test]
extract ES logs only for svl (#202927)\n\n## Summary\r\n\r\nPR fixes the
issue reported by @dolaru when running stateful FTR\r\nenvironment
without docker setup locally:\r\n\r\n```\r\n info [es] killing node\r\n
info [es] stopping node scout\r\n info [es] no debug files found,
assuming es did not write any\r\n info [es] cleanup complete\r\nERROR
UNHANDLED ERROR\r\nERROR Error: Command failed with exit code 1: docker
ps -a --format {{.Names}}\r\n error during connect: Get
\"http://docker.example.com/v1.47/containers/json?all=1\": command [ssh
-o ConnectTimeout=30 -T -l dolaru -- debian-12-vm docker system
dial-stdio] has exited with exit status 255, make sure the URL is valid,
and Docker 18.09 or later is installed on the remote host: stderr=ssh:
Could not resolve hostname dolaru-m2-mbp-debian.local: nodename nor
servname provided, or not known\r\n at makeError
(/Users/dolaru/workspace/kibana/node_modules/execa/lib/error.js:60:11)\r\n
at handlePromise
(/Users/dolaru/workspace/kibana/node_modules/execa/index.js:118:26)\r\n
at processTicksAndRejections
(node:internal/process/task_queues:95:5)\r\n at extractAndArchiveLogs
(extract_and_archive_logs.ts:34:41)\r\n at
run_elasticsearch.ts:86:5\r\n```\r\n\r\nSince we don't need it for
stateful ES instance, I added condition.\r\nkbn-scout had the same
issue, so I exported `cleanupElasticsearch` from\r\n`kbn-test` to avoid
code
duplication","sha":"cdb5a2dca2f42edbe2be47c970423d7dbd1ce99e"}},{"branch":"8.x","label":"v8.18.0","labelRegex":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ikuni17 Ikuni17 Ikuni17 approved these changes

@dolaru dolaru dolaru approved these changes

Assignees

@dmlemeshko dmlemeshko

Labels
backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dmlemeshko @elasticmachine @kibanamachine @dolaru @Ikuni17