[Response Ops][Task Manager] Changing task manager schedule.interval schema to string from duration
#204413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ymao1
changed the title
schedule.interval schema to string from duration
ymao1
added
release_note:skip
|
Pinging @elastic/response-ops (Team:ResponseOps) |
pmuellr
reviewed
Dec 16, 2024
| @@ -7,6 +7,26 @@ | |||
|
|
|||
| import { schema } from '@kbn/config-schema'; | |||
|
|
|||
| const SECONDS_REGEX = /^[1-9][0-9]*s$/; | |||
There was a problem hiding this comment.
Can we use one of the functions from here, instead? x-pack/plugins/task_manager/server/lib/intervals.ts
💚 Build Succeeded
Metrics [docs]
History
cc @ymao1 |
💚 Build Succeeded
Metrics [docs]
History
cc @ymao1 |
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 17, 2024
…` schema to string from duration (elastic#204413) ## Summary Currently, when task manager schema changes are migrated down (which can occur during a release when there are multiple Kibana nodes running and they get updated one after another), we are running into this bug: elastic#204395 where the task `schedule.interval` gets mutated from expected values (like `60s`) to unallowed (but still valid for the schema) values (like `PT1M`). This changes the schema for `schedule.interval` to use a string with validation function. ## To verify 1. Run Kibana on `main` and create some rules that run frequently. 2. "Upgrade" to this PR branch and verify that rules continue to run. 3. "Downgrade" back to `main` and verify that rules continue to run. (cherry picked from commit ccdd662)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 18, 2024
…le.interval` schema to string from duration (#204413) (#204669) # Backport This will backport the following commits from `main` to `8.x`: - [[Response Ops][Task Manager] Changing task manager `schedule.interval` schema to string from duration (#204413)](#204413) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ying Mao","email":"ying.mao@elastic.co"},"sourceCommit":{"committedDate":"2024-12-17T22:41:20Z","message":"[Response Ops][Task Manager] Changing task manager `schedule.interval` schema to string from duration (#204413)\n\n## Summary\r\n\r\nCurrently, when task manager schema changes are migrated down (which can\r\noccur during a release when there are multiple Kibana nodes running and\r\nthey get updated one after another), we are running into this bug:\r\nhttps://github.com//issues/204395 where the task\r\n`schedule.interval` gets mutated from expected values (like `60s`) to\r\nunallowed (but still valid for the schema) values (like `PT1M`).\r\n\r\nThis changes the schema for `schedule.interval` to use a string with\r\nvalidation function.\r\n\r\n## To verify\r\n1. Run Kibana on `main` and create some rules that run frequently.\r\n2. \"Upgrade\" to this PR branch and verify that rules continue to run.\r\n3. \"Downgrade\" back to `main` and verify that rules continue to run.","sha":"ccdd662a053f9d02fe1ea04afe2bdd80827459c0","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Feature:Task Manager","Team:ResponseOps","v9.0.0","backport:prev-minor","v8.18.0"],"title":"[Response Ops][Task Manager] Changing task manager `schedule.interval` schema to string from duration","number":204413,"url":"https://github.com/elastic/kibana/pull/204413","mergeCommit":{"message":"[Response Ops][Task Manager] Changing task manager `schedule.interval` schema to string from duration (#204413)\n\n## Summary\r\n\r\nCurrently, when task manager schema changes are migrated down (which can\r\noccur during a release when there are multiple Kibana nodes running and\r\nthey get updated one after another), we are running into this bug:\r\nhttps://github.com//issues/204395 where the task\r\n`schedule.interval` gets mutated from expected values (like `60s`) to\r\nunallowed (but still valid for the schema) values (like `PT1M`).\r\n\r\nThis changes the schema for `schedule.interval` to use a string with\r\nvalidation function.\r\n\r\n## To verify\r\n1. Run Kibana on `main` and create some rules that run frequently.\r\n2. \"Upgrade\" to this PR branch and verify that rules continue to run.\r\n3. \"Downgrade\" back to `main` and verify that rules continue to run.","sha":"ccdd662a053f9d02fe1ea04afe2bdd80827459c0"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204413","number":204413,"mergeCommit":{"message":"[Response Ops][Task Manager] Changing task manager `schedule.interval` schema to string from duration (#204413)\n\n## Summary\r\n\r\nCurrently, when task manager schema changes are migrated down (which can\r\noccur during a release when there are multiple Kibana nodes running and\r\nthey get updated one after another), we are running into this bug:\r\nhttps://github.com//issues/204395 where the task\r\n`schedule.interval` gets mutated from expected values (like `60s`) to\r\nunallowed (but still valid for the schema) values (like `PT1M`).\r\n\r\nThis changes the schema for `schedule.interval` to use a string with\r\nvalidation function.\r\n\r\n## To verify\r\n1. Run Kibana on `main` and create some rules that run frequently.\r\n2. \"Upgrade\" to this PR branch and verify that rules continue to run.\r\n3. \"Downgrade\" back to `main` and verify that rules continue to run.","sha":"ccdd662a053f9d02fe1ea04afe2bdd80827459c0"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Ying Mao <ying.mao@elastic.co>
JoseLuisGJ
pushed a commit
to JoseLuisGJ/kibana
that referenced
this pull request
Dec 19, 2024
…` schema to string from duration (elastic#204413) ## Summary Currently, when task manager schema changes are migrated down (which can occur during a release when there are multiple Kibana nodes running and they get updated one after another), we are running into this bug: elastic#204395 where the task `schedule.interval` gets mutated from expected values (like `60s`) to unallowed (but still valid for the schema) values (like `PT1M`). This changes the schema for `schedule.interval` to use a string with validation function. ## To verify 1. Run Kibana on `main` and create some rules that run frequently. 2. "Upgrade" to this PR branch and verify that rules continue to run. 3. "Downgrade" back to `main` and verify that rules continue to run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, when task manager schema changes are migrated down (which can occur during a release when there are multiple Kibana nodes running and they get updated one after another), we are running into this bug: #204395 where the task
schedule.intervalgets mutated from expected values (like60s) to unallowed (but still valid for the schema) values (likePT1M).This changes the schema for
schedule.intervalto use a string with validation function.To verify
mainand create some rules that run frequently.mainand verify that rules continue to run.