[8.x] [HTTP] Default to `oldest` in dev (#203225) #204609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary Changes the default HTTP version resolution in dev to `oldest` (matches non-dev). The original intention was to guide developers to always sending a versioned header when interacting with Kibana. In practice, however, developers just set-and-forget the following configuration to get around this annoyance: ```yaml server.versioned.versionResolution: 'oldest' ``` ...undoing the original intention. Having this guidance does not justify the confusion/annoyance that this dev-only default creates and so this proposal simply removes it. To better guide developers we can consider other options like: make `version` required in core's HTTP client interface (lots of updates...), doing something in tests, adding docs, something else or any combo of these. Given the fact that developers generally discover this workaround and undo the originally intended guidance, I'm proposing not blocking on first having another approach in place. (cherry picked from commit c1bda1d)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Please do not merge this pull request. We disabled auto-merge because we are trying to merge a this big PR as part of sustainable architecture migration which is impossible with ever increasing stream of backports. We will resume the automerge after our PR is merged. Reach out to #sustainable-kibana-architecture for more info. |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
cc @jloleysens |
|
Auto-merge has been re-enabled. Thank you for your patience. :heart |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:Questions ?
Please refer to the Backport tool documentation