Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] removed extraneous '/downloads' in path for curl commands #204660

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

Supplementing
Copy link
Contributor

@Supplementing Supplementing commented Dec 17, 2024

Summary

Removed the extra /downloads portion of the curl command, as it is already returned in the base url.
Closes #204462

Before:
image

After:
image

@Supplementing Supplementing added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:Fleet Team label for Observability Data Collection Fleet team labels Dec 17, 2024
@Supplementing Supplementing requested a review from a team as a code owner December 17, 2024 21:14
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@Supplementing Supplementing added the bug Fixes for quality problems that affect the customer experience label Dec 17, 2024
@nchaulet nchaulet changed the title removed extraneous '/downloads' in path for curl commands [Fleet] removed extraneous '/downloads' in path for curl commands Dec 17, 2024
@nchaulet nchaulet added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) and removed backport:skip This commit does not require backporting labels Dec 17, 2024
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Integration Tests #7 / Migration actions - serverless environment reindex & waitForReindexTask resolves right and proceeds to add missing documents if there are some existing docs conflicts

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 1.7MB 1.7MB -50.0B

Copy link
Contributor

@juliaElastic juliaElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Supplementing Supplementing merged commit e29a14d into elastic:main Dec 18, 2024
20 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12396296386

@Supplementing Supplementing deleted the fix-curl-command-typos branch December 18, 2024 15:37
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 18, 2024
…astic#204660)

## Summary

Removed the extra `/downloads` portion of the curl command, as it is
already returned in the base url.
Closes elastic#204462

Before:

![image](https://github.com/user-attachments/assets/5a156aca-ea2b-4703-97b3-f7a5e4ae6ab1)

After:

![image](https://github.com/user-attachments/assets/d5c9f0d4-1452-40c1-b8df-4473584ac288)

(cherry picked from commit e29a14d)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 18, 2024
…url commands (#204660) (#204779)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Fleet] removed extraneous '/downloads' in path for curl
commands (#204660)](#204660)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Mason
Herron","email":"46727170+Supplementing@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-12-18T15:37:32Z","message":"[Fleet]
removed extraneous '/downloads' in path for curl commands
(#204660)\n\n## Summary\r\n\r\nRemoved the extra `/downloads` portion of
the curl command, as it is\r\nalready returned in the base
url.\r\nCloses #204462 \r\n\r\nBefore:
\r\n\r\n![image](https://github.com/user-attachments/assets/5a156aca-ea2b-4703-97b3-f7a5e4ae6ab1)\r\n\r\nAfter:
\r\n\r\n![image](https://github.com/user-attachments/assets/d5c9f0d4-1452-40c1-b8df-4473584ac288)","sha":"e29a14d623d1034f6ea12bce679a8fceb95b4cdc","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:Fleet","v9.0.0","backport:prev-minor"],"title":"[Fleet]
removed extraneous '/downloads' in path for curl
commands","number":204660,"url":"https://github.com/elastic/kibana/pull/204660","mergeCommit":{"message":"[Fleet]
removed extraneous '/downloads' in path for curl commands
(#204660)\n\n## Summary\r\n\r\nRemoved the extra `/downloads` portion of
the curl command, as it is\r\nalready returned in the base
url.\r\nCloses #204462 \r\n\r\nBefore:
\r\n\r\n![image](https://github.com/user-attachments/assets/5a156aca-ea2b-4703-97b3-f7a5e4ae6ab1)\r\n\r\nAfter:
\r\n\r\n![image](https://github.com/user-attachments/assets/d5c9f0d4-1452-40c1-b8df-4473584ac288)","sha":"e29a14d623d1034f6ea12bce679a8fceb95b4cdc"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204660","number":204660,"mergeCommit":{"message":"[Fleet]
removed extraneous '/downloads' in path for curl commands
(#204660)\n\n## Summary\r\n\r\nRemoved the extra `/downloads` portion of
the curl command, as it is\r\nalready returned in the base
url.\r\nCloses #204462 \r\n\r\nBefore:
\r\n\r\n![image](https://github.com/user-attachments/assets/5a156aca-ea2b-4703-97b3-f7a5e4ae6ab1)\r\n\r\nAfter:
\r\n\r\n![image](https://github.com/user-attachments/assets/d5c9f0d4-1452-40c1-b8df-4473584ac288)","sha":"e29a14d623d1034f6ea12bce679a8fceb95b4cdc"}}]}]
BACKPORT-->

Co-authored-by: Mason Herron <46727170+Supplementing@users.noreply.github.com>
JoseLuisGJ pushed a commit to JoseLuisGJ/kibana that referenced this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo in curl command for a standalone Agent install
5 participants