-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] removed extraneous '/downloads' in path for curl commands #204660
[Fleet] removed extraneous '/downloads' in path for curl commands #204660
Conversation
Pinging @elastic/fleet (Team:Fleet) |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Starting backport for target branches: 8.x |
…astic#204660) ## Summary Removed the extra `/downloads` portion of the curl command, as it is already returned in the base url. Closes elastic#204462 Before: ![image](https://github.com/user-attachments/assets/5a156aca-ea2b-4703-97b3-f7a5e4ae6ab1) After: ![image](https://github.com/user-attachments/assets/d5c9f0d4-1452-40c1-b8df-4473584ac288) (cherry picked from commit e29a14d)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…url commands (#204660) (#204779) # Backport This will backport the following commits from `main` to `8.x`: - [[Fleet] removed extraneous '/downloads' in path for curl commands (#204660)](#204660) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Mason Herron","email":"46727170+Supplementing@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-12-18T15:37:32Z","message":"[Fleet] removed extraneous '/downloads' in path for curl commands (#204660)\n\n## Summary\r\n\r\nRemoved the extra `/downloads` portion of the curl command, as it is\r\nalready returned in the base url.\r\nCloses #204462 \r\n\r\nBefore: \r\n\r\n![image](https://github.com/user-attachments/assets/5a156aca-ea2b-4703-97b3-f7a5e4ae6ab1)\r\n\r\nAfter: \r\n\r\n![image](https://github.com/user-attachments/assets/d5c9f0d4-1452-40c1-b8df-4473584ac288)","sha":"e29a14d623d1034f6ea12bce679a8fceb95b4cdc","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:Fleet","v9.0.0","backport:prev-minor"],"title":"[Fleet] removed extraneous '/downloads' in path for curl commands","number":204660,"url":"https://github.com/elastic/kibana/pull/204660","mergeCommit":{"message":"[Fleet] removed extraneous '/downloads' in path for curl commands (#204660)\n\n## Summary\r\n\r\nRemoved the extra `/downloads` portion of the curl command, as it is\r\nalready returned in the base url.\r\nCloses #204462 \r\n\r\nBefore: \r\n\r\n![image](https://github.com/user-attachments/assets/5a156aca-ea2b-4703-97b3-f7a5e4ae6ab1)\r\n\r\nAfter: \r\n\r\n![image](https://github.com/user-attachments/assets/d5c9f0d4-1452-40c1-b8df-4473584ac288)","sha":"e29a14d623d1034f6ea12bce679a8fceb95b4cdc"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204660","number":204660,"mergeCommit":{"message":"[Fleet] removed extraneous '/downloads' in path for curl commands (#204660)\n\n## Summary\r\n\r\nRemoved the extra `/downloads` portion of the curl command, as it is\r\nalready returned in the base url.\r\nCloses #204462 \r\n\r\nBefore: \r\n\r\n![image](https://github.com/user-attachments/assets/5a156aca-ea2b-4703-97b3-f7a5e4ae6ab1)\r\n\r\nAfter: \r\n\r\n![image](https://github.com/user-attachments/assets/d5c9f0d4-1452-40c1-b8df-4473584ac288)","sha":"e29a14d623d1034f6ea12bce679a8fceb95b4cdc"}}]}] BACKPORT--> Co-authored-by: Mason Herron <46727170+Supplementing@users.noreply.github.com>
…astic#204660) ## Summary Removed the extra `/downloads` portion of the curl command, as it is already returned in the base url. Closes elastic#204462 Before: ![image](https://github.com/user-attachments/assets/5a156aca-ea2b-4703-97b3-f7a5e4ae6ab1) After: ![image](https://github.com/user-attachments/assets/d5c9f0d4-1452-40c1-b8df-4473584ac288)
Summary
Removed the extra
/downloads
portion of the curl command, as it is already returned in the base url.Closes #204462
Before:
After: