Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [Cloud Security] Bug fix - show origin event's with primary color instead of danger (#204425) #204663

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

\r\n\r\n### Questions ?\r\nPlease refer to the [Backport tool\r\ndocumentation](https://github.com/sqren/backport)\r\n\r\n\r\n\r\nCo-authored-by: Kfir Peled <61654899+kfirpeled@users.noreply.github.com>"}}]}] BACKPORT-->

@kfirpeled kfirpeled disabled auto-merge December 17, 2024 23:04
@kfirpeled
Copy link
Contributor

disabled auto-merge, waits for #204474

…tead of danger (elastic#204425)

## Summary

Bug description:

**Actual:** The node's color is red when exploring events through
Explore or Timeline.
**The expected** color of events is blue.

Before:

![385007418-f0a6bd7e-dbc9-43ad-99b8-a07bcad85075](https://github.com/user-attachments/assets/7bf198f3-9a32-4d27-84db-3e97b5bf312b)

After:

https://github.com/user-attachments/assets/f1a10deb-65f5-43be-a351-6fca34f855cb

https://github.com/user-attachments/assets/223534f4-09a2-4b41-85bc-c2195dd153ba

**How to test this PR:**

- Enable the feature flag

`kibana.dev.yml`:

```yaml
uiSettings.overrides.securitySolution:enableVisualizationsInFlyout: true
xpack.securitySolution.enableExperimental: ['graphVisualizationInFlyoutEnabled']
```

- Load mocked data:

```bash
node scripts/es_archiver load x-pack/test/cloud_security_posture_functional/es_archives/logs_gcp_audit \
  --es-url http://elastic:changeme@localhost:9200 \
  --kibana-url http://elastic:changeme@localhost:5601

node scripts/es_archiver load x-pack/test/cloud_security_posture_functional/es_archives/security_alerts \
  --es-url http://elastic:changeme@localhost:9200 \
  --kibana-url http://elastic:changeme@localhost:5601
```

- Make sure you include data from Oct 13 2024. (in the video I use Last
year)

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed

(cherry picked from commit 2c5544c)
@kibanamachine kibanamachine enabled auto-merge (squash) December 18, 2024 10:01
@kibanamachine kibanamachine merged commit efeb297 into elastic:8.x Dec 18, 2024
8 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 19.1MB 19.1MB +1.6KB

History

cc @kfirpeled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants