Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sustainable Kibana Architecture: Move modules owned by @elastic/kibana-presentation #204843

Open
wants to merge 29 commits into
base: main
Choose a base branch
from

Conversation

ThomThomson
Copy link
Contributor

@ThomThomson ThomThomson commented Dec 18, 2024

Summary

This PR aims at relocating some of the Kibana modules (plugins and packages) into a new folder structure, according to the Sustainable Kibana Architecture initiative.

Important

  • We kindly ask you to:
    • Manually fix the errors in the error section below (if there are any).
    • Search for the packages[\/\\] and plugins[\/\\] patterns in the source code (Babel and Eslint config files), and update them appropriately.
    • Manually review .buildkite/scripts/pipelines/pull_request/pipeline.ts to ensure that any CI pipeline customizations continue to be correctly applied after the changed path names
    • Review all of the updated files, specially the .ts and .js files listed in the sections below, as some of them contain relative paths that have been updated.
    • Think of potential impact of the move, including tooling and configuration files that can be pointing to the relocated modules. E.g.:
      • customised eslint rules
      • docs pointing to source code

Note

  • This PR has been auto-generated.
  • Any manual contributions will be lost if the 'relocate' script is re-run.
  • Try to obtain the missing reviews / approvals before applying manual fixes, and/or keep your changes in a .patch / git stash.
  • Please use #sustainable_kibana_architecture Slack channel for feedback.

Are you trying to rebase this PR to solve merge conflicts? Please follow the steps describe here.

21 plugin(s) are going to be relocated:

Id Target folder
@kbn/canvas-plugin x-pack/platform/plugins/private/canvas
@kbn/controls-plugin src/platform/plugins/shared/controls
@kbn/dashboard-enhanced-plugin x-pack/platform/plugins/shared/dashboard_enhanced
@kbn/dashboard-plugin src/platform/plugins/shared/dashboard
@kbn/embeddable-enhanced-plugin x-pack/platform/plugins/shared/embeddable_enhanced
@kbn/embeddable-plugin src/platform/plugins/shared/embeddable
@kbn/expression-error-plugin src/platform/plugins/shared/expression_error
@kbn/expression-image-plugin src/platform/plugins/shared/expression_image
@kbn/expression-metric-plugin src/platform/plugins/shared/expression_metric
@kbn/expression-repeat-image-plugin src/platform/plugins/shared/expression_repeat_image
@kbn/expression-reveal-image-plugin src/platform/plugins/shared/expression_reveal_image
@kbn/expression-shape-plugin src/platform/plugins/shared/expression_shape
@kbn/file-upload-plugin x-pack/platform/plugins/private/file_upload
@kbn/input-control-vis-plugin src/platform/plugins/private/input_control_vis
@kbn/inspector-plugin src/platform/plugins/shared/inspector
@kbn/links-plugin src/platform/plugins/private/links
@kbn/maps-ems-plugin src/platform/plugins/private/maps_ems
@kbn/maps-plugin x-pack/platform/plugins/shared/maps
@kbn/presentation-panel-plugin src/platform/plugins/private/presentation_panel
@kbn/presentation-util-plugin src/platform/plugins/shared/presentation_util
@kbn/vis-type-markdown-plugin src/platform/plugins/private/vis_type_markdown

6 packages(s) are going to be relocated:

Id Target folder
@kbn/flot-charts src/platform/packages/shared/kbn-flot-charts
@kbn/mapbox-gl src/platform/packages/private/kbn-mapbox-gl
@kbn/maps-vector-tile-utils x-pack/platform/packages/private/maps/vector_tile_utils
@kbn/panel-loader src/platform/packages/private/kbn-panel-loader
@kbn/presentation-containers src/platform/packages/shared/presentation/presentation_containers
@kbn/presentation-publishing src/platform/packages/shared/presentation/presentation_publishing
Updated references
./.eslintignore
./.eslintrc.js
./.github/codeql/codeql-config.yml
./.github/paths-labeller.yml
./.i18nrc.json
./docs/developer/best-practices/index.asciidoc
./docs/developer/contributing/development-tests.asciidoc
./docs/developer/plugin-list.asciidoc
./legacy_rfcs/text/0018_timeslider.md
./package.json
./packages/kbn-cli-dev-mode/src/watcher.ts
./packages/kbn-docs-utils/src/utils.test.ts
./packages/kbn-repo-packages/package-map.json
./packages/kbn-test/src/jest/setup/polyfills.jsdom.js
./packages/kbn-ts-projects/config-paths.json
./src/dev/build/tasks/build_canvas_shareable_runtime.ts
./src/dev/build/tasks/create_archives_sources_task.ts
./src/dev/code_coverage/ingest_coverage/__tests__/mocks/team_assign_mock.txt
./src/dev/precommit_hook/casing_check_config.js
./src/dev/storybook/aliases.ts
./src/platform/packages/private/kbn-panel-loader/jest.config.js
./src/platform/packages/shared/presentation/presentation_containers/jest.config.js
./src/platform/packages/shared/presentation/presentation_publishing/jest.config.js
./src/platform/plugins/private/input_control_vis/jest.config.js
./src/platform/plugins/private/links/jest.config.js
./src/platform/plugins/private/maps_ems/jest.config.js
./src/platform/plugins/private/presentation_panel/jest.config.js
./src/platform/plugins/private/vis_type_markdown/jest.config.js
./src/platform/plugins/shared/controls/jest.config.js
./src/platform/plugins/shared/dashboard/jest.config.js
./src/platform/plugins/shared/dashboard/public/dashboard_container/component/empty_screen/__snapshots__/dashboard_empty_screen.test.tsx.snap
./src/platform/plugins/shared/embeddable/README.md
./src/platform/plugins/shared/embeddable/jest.config.js
./src/platform/plugins/shared/expression_image/jest.config.js
./src/platform/plugins/shared/expression_metric/jest.config.js
./src/platform/plugins/shared/expression_repeat_image/jest.config.js
./src/platform/plugins/shared/expression_reveal_image/jest.config.js
./src/platform/plugins/shared/expression_shape/jest.config.js
./src/platform/plugins/shared/inspector/jest.config.js
./src/platform/plugins/shared/presentation_util/jest.config.js
./src/platform/plugins/shared/presentation_util/storybook/manager.ts
./src/plugins/visualizations/public/visualize_app/utils/migrate_app_state.ts
./tsconfig.base.json
./x-pack/.i18nrc.json
./x-pack/platform/packages/private/maps/vector_tile_utils/jest.config.js
./x-pack/platform/plugins/private/canvas/jest.config.js
./x-pack/platform/plugins/private/canvas/scripts/jest.js
./x-pack/platform/plugins/private/canvas/shareable_runtime/constants.js
./x-pack/platform/plugins/private/canvas/storybook/canvas_webpack.ts
./x-pack/platform/plugins/private/file_upload/jest.config.js
./x-pack/platform/plugins/shared/dashboard_enhanced/common/drilldowns/dashboard_drilldown/constants.ts
./x-pack/platform/plugins/shared/dashboard_enhanced/jest.config.js
./x-pack/platform/plugins/shared/dashboard_enhanced/public/services/drilldowns/embeddable_to_dashboard_drilldown/constants.ts
./x-pack/platform/plugins/shared/embeddable_enhanced/jest.config.js
./x-pack/platform/plugins/shared/maps/README.md
./x-pack/platform/plugins/shared/maps/jest.config.js
./x-pack/plugins/reporting/server/config/ui_settings.ts
./x-pack/test/api_integration/apis/maps/fonts_api.js
./yarn.lock
.github/CODEOWNERS
Updated relative paths
src/platform/packages/private/kbn-mapbox-gl/tsconfig.json:2
src/platform/packages/private/kbn-panel-loader/jest.config.js:12
src/platform/packages/private/kbn-panel-loader/tsconfig.json:2
src/platform/packages/shared/kbn-flot-charts/tsconfig.json:2
src/platform/packages/shared/presentation/presentation_containers/jest.config.js:12
src/platform/packages/shared/presentation/presentation_containers/tsconfig.json:2
src/platform/packages/shared/presentation/presentation_publishing/jest.config.js:12
src/platform/packages/shared/presentation/presentation_publishing/tsconfig.json:2
src/platform/plugins/private/input_control_vis/jest.config.js:12
src/platform/plugins/private/input_control_vis/tsconfig.json:2
src/platform/plugins/private/links/jest.config.js:12
src/platform/plugins/private/links/public/_mixins.scss:1
src/platform/plugins/private/links/tsconfig.json:2
src/platform/plugins/private/maps_ems/jest.config.js:12
src/platform/plugins/private/maps_ems/tsconfig.json:2
src/platform/plugins/private/presentation_panel/jest.config.js:12
src/platform/plugins/private/presentation_panel/tsconfig.json:2
src/platform/plugins/private/presentation_panel/tsconfig.json:6
src/platform/plugins/private/vis_type_markdown/jest.config.js:12
src/platform/plugins/private/vis_type_markdown/tsconfig.json:2
src/platform/plugins/shared/controls/jest.config.js:12
src/platform/plugins/shared/controls/tsconfig.json:12
src/platform/plugins/shared/controls/tsconfig.json:2
src/platform/plugins/shared/dashboard/jest.config.js:12
src/platform/plugins/shared/dashboard/tsconfig.json:2
src/platform/plugins/shared/embeddable/jest.config.js:12
src/platform/plugins/shared/embeddable/tsconfig.json:2
src/platform/plugins/shared/expression_error/tsconfig.json:2
src/platform/plugins/shared/expression_image/jest.config.js:12
src/platform/plugins/shared/expression_image/tsconfig.json:2
src/platform/plugins/shared/expression_metric/jest.config.js:12
src/platform/plugins/shared/expression_metric/tsconfig.json:2
src/platform/plugins/shared/expression_repeat_image/jest.config.js:12
src/platform/plugins/shared/expression_repeat_image/tsconfig.json:2
src/platform/plugins/shared/expression_reveal_image/jest.config.js:12
src/platform/plugins/shared/expression_reveal_image/tsconfig.json:2
src/platform/plugins/shared/expression_shape/jest.config.js:12
src/platform/plugins/shared/expression_shape/tsconfig.json:2
src/platform/plugins/shared/inspector/jest.config.js:12
src/platform/plugins/shared/inspector/tsconfig.json:2
src/platform/plugins/shared/presentation_util/jest.config.js:12
src/platform/plugins/shared/presentation_util/storybook/main.ts:17
src/platform/plugins/shared/presentation_util/tsconfig.json:13
src/platform/plugins/shared/presentation_util/tsconfig.json:2
x-pack/platform/packages/private/maps/vector_tile_utils/jest.config.js:10
x-pack/platform/packages/private/maps/vector_tile_utils/tsconfig.json:2
x-pack/platform/plugins/private/canvas/CONTRIBUTING.md:3
x-pack/platform/plugins/private/canvas/PLUGINS.mdx:174
x-pack/platform/plugins/private/canvas/PLUGINS.mdx:175
x-pack/platform/plugins/private/canvas/PLUGINS.mdx:63
x-pack/platform/plugins/private/canvas/PLUGINS.mdx:64
x-pack/platform/plugins/private/canvas/jest.config.js:10
x-pack/platform/plugins/private/canvas/shareable_runtime/constants.js:11
x-pack/platform/plugins/private/canvas/storybook/constants.ts:10
x-pack/platform/plugins/private/canvas/storybook/storyshots.skipped_test.tsx:86
x-pack/platform/plugins/private/canvas/tsconfig.json:16
x-pack/platform/plugins/private/canvas/tsconfig.json:2
x-pack/platform/plugins/private/canvas/tsconfig.json:29
x-pack/platform/plugins/private/file_upload/jest.config.js:10
x-pack/platform/plugins/private/file_upload/tsconfig.json:2
x-pack/platform/plugins/shared/dashboard_enhanced/jest.config.js:10
x-pack/platform/plugins/shared/dashboard_enhanced/tsconfig.json:2
x-pack/platform/plugins/shared/embeddable_enhanced/jest.config.js:10
x-pack/platform/plugins/shared/embeddable_enhanced/tsconfig.json:2
x-pack/platform/plugins/shared/maps/jest.config.js:10
x-pack/platform/plugins/shared/maps/public/_main.scss:1
x-pack/platform/plugins/shared/maps/tsconfig.json:12
x-pack/platform/plugins/shared/maps/tsconfig.json:2

Copy link
Contributor

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@ThomThomson ThomThomson changed the title Kbn team 1309 move kibana presentation Sustainable Kibana Architecture: Move some modules owned by @elastic/kibana-presentation Dec 18, 2024
@ThomThomson ThomThomson force-pushed the kbn-team-1309-move-kibana-presentation branch from 05cc596 to b5c6a62 Compare December 18, 2024 23:29
@ThomThomson
Copy link
Contributor Author

This is a potential replacement for #202664

@ThomThomson
Copy link
Contributor Author

/ci

1 similar comment
@gsoldevila
Copy link
Contributor

/ci

@gsoldevila gsoldevila added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) plugin groups Relocate all plugins and packages under their respective platform/solution groups labels Dec 19, 2024
@ThomThomson ThomThomson marked this pull request as ready for review December 19, 2024 16:54
@ThomThomson ThomThomson requested a review from a team as a code owner December 19, 2024 16:54
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@nreese nreese self-requested a review December 19, 2024 17:34
@ThomThomson ThomThomson force-pushed the kbn-team-1309-move-kibana-presentation branch from f3d9184 to ec2cd0f Compare December 19, 2024 17:43
Copy link
Contributor

@ryankeairns ryankeairns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SCSS only

Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kibana-presentation changes LGTM
reviewed new file structure only.

@ThomThomson ThomThomson force-pushed the kbn-team-1309-move-kibana-presentation branch from d56ea98 to 36bf2db Compare December 19, 2024 21:05
@ThomThomson ThomThomson requested a review from a team as a code owner December 19, 2024 21:05
@nickpeihl nickpeihl force-pushed the kbn-team-1309-move-kibana-presentation branch from 8a21bfe to dff69ff Compare December 21, 2024 21:05
@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 22, 2024

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #2 / DashboardEmptyScreen renders correctly with edit mode
  • [job] [logs] Jest Tests #2 / DashboardEmptyScreen renders correctly with edit mode
  • [job] [logs] Jest Tests #2 / DashboardEmptyScreen renders correctly with readonly and edit mode
  • [job] [logs] Jest Tests #2 / DashboardEmptyScreen renders correctly with readonly and edit mode
  • [job] [logs] Jest Tests #2 / DashboardEmptyScreen renders correctly with readonly mode
  • [job] [logs] Jest Tests #2 / DashboardEmptyScreen renders correctly with readonly mode
  • [job] [logs] Jest Tests #2 / DashboardEmptyScreen renders correctly with view mode
  • [job] [logs] Jest Tests #2 / DashboardEmptyScreen renders correctly with view mode

Metrics [docs]

Unknown metric groups

ESLint disabled in files

id before after diff
dashboardEnhanced 1 0 -1
expressionError 1 0 -1
expressionImage 1 0 -1
expressionMetric 1 0 -1
expressionRepeatImage 1 0 -1
expressionRevealImage 1 0 -1
inspector 2 1 -1
total -7

Total ESLint disabled count

id before after diff
dashboardEnhanced 5 4 -1
expressionError 6 5 -1
expressionImage 2 1 -1
expressionMetric 2 1 -1
expressionRepeatImage 2 1 -1
expressionRevealImage 2 1 -1
inspector 4 3 -1
total -7

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) plugin groups Relocate all plugins and packages under their respective platform/solution groups release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants