Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deleted messages sometimes viewable in roomlist preview #1170

Closed
bbhtt opened this issue Aug 29, 2023 · 3 comments
Closed

Deleted messages sometimes viewable in roomlist preview #1170

bbhtt opened this issue Aug 29, 2023 · 3 comments
Assignees
@bmarty
Labels
A-Timeline O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue X-Release-Blocker

Comments

@bbhtt
Copy link

bbhtt commented Aug 29, 2023

Steps to reproduce

  1. Send message to a room
  2. Redact that message
  3. See that in the roomlist preview the message is still viewable

Sometimes this happens once the message is deleted and the roomlist is opened and sometimes when the app is closed and reopened (see this case in the video)

It's a bit hard to reproduce but I can send logs after I've seen it if it helps. Please let me know.

The message "ef" is viewable in preview when it is deleted in the room

video.mp4

Outcome

What did you expect?

Message shouldn't be viewable in preview

What happened instead?

Message is viewable in preview

Your phone model

Nokia C3

Operating system version

Android 10

Application version and app store

0.1.5 (40001050)

Homeserver

matrix.org

Will you send logs?

No

Are you willing to provide a PR?

No
@bbhtt bbhtt added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Aug 29, 2023
@julioromano julioromano added A-Timeline O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Aug 29, 2023
@jmartinesp
Copy link
Member

This looks like a Sliding Sync / Rust SDK issue, it has its counterpart on iOS in element-hq/element-x-ios#1441.

@kittykat kittykat added X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue X-Release-Blocker labels Sep 8, 2023
@bmarty
Copy link
Member

bmarty commented Sep 12, 2023

I will check with the latest SDK (currently being built), it will include matrix-org/matrix-rust-sdk#2512

@bmarty bmarty self-assigned this Sep 12, 2023
@jplatte jplatte removed their assignment Sep 12, 2023
@bmarty
Copy link
Member

bmarty commented Sep 13, 2023

OK, I confirm this is working as expected on the latest nightly:

RedactedMessageRoomList

Note that the avatar vertical position change is probably due to the larger font size I use on my emu.

@bmarty bmarty closed this as completed Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmarty bmarty

Labels
A-Timeline O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue X-Release-Blocker
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@kittykat @jmartinesp @jplatte @julioromano @bmarty @bbhtt