Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display in Notifications settings the default mode for the group and the direct chats #532

Closed
Tracked by #1676
giomfo opened this issue Jun 6, 2023 · 3 comments
Closed
Tracked by #1676
Assignees
Labels
A-Notifications T-Task Refactoring, enabling or disabling functionality, other engineering tasks

Comments

@giomfo
Copy link
Member

giomfo commented Jun 6, 2023

Description

Add in the notifications settings a section "Notify me for" to provide the default setting for group chats and direct chats.

The default value for group chats depends on 2 Underride rules: .m.rule.message and .m.rule.encrypted. We will consider only their enabled attribute:

  • if both are enabled -> "All Messages"
  • if both are disabled -> "Mentions and Keywords"
  • if only one is enabled -> display a banner to let user know the configuration is not supported. A button is available to fix the pb. In that case, we enabled the second one to fix the pb.

The default value for group chats depends on 2 Underride rules: .m.rule.encrypted_room_one_to_one and .m.rule.room_one_to_one. We will consider only their enabled attribute:

  • if both are enabled -> "All Messages"
  • if both are disabled -> "Mentions and Keywords"
  • if only one is enabled -> display a banner to let user know the configuration is not supported. A button is available to fix the pb. In that case, we enabled the second one to fix the pb.

Suggested Design

image
@giomfo
Copy link
Member Author

giomfo commented Aug 11, 2023

About the "banner" displayed when the config is not supported, the discussion took place in the related iOS issue here.

@amshakal can you please provide an Android version of the design for this "banner/alert"?

@giomfo
Copy link
Member Author

giomfo commented Aug 17, 2023

@yostyle Do you agree with @amshakal that the option4 is the best?

FYI here is my last wording suggestion

@giomfo
Copy link
Member Author

giomfo commented Aug 25, 2023

#1037 implement this issue without handling the potential unsupported configuration.
FYI option3 has been the one selected for iOS (see with @nimau for more details)

@kittykat kittykat added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Notifications T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

No branches or pull requests

3 participants