Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invites in room membership list don't local echo (or remote echo). #1189

Open
ara4n opened this issue Jun 28, 2023 · 8 comments
Open

Invites in room membership list don't local echo (or remote echo). #1189

ara4n opened this issue Jun 28, 2023 · 8 comments
Labels
A-DMs A-Local echo A-Room-List O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Maybe-Release-Blocker X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue

Comments

@ara4n
Copy link
Member

ara4n commented Jun 28, 2023

Steps to reproduce

  1. Go to a room
  2. Invite a user to it
  3. See absolutely no evidence in the member list that you've invited a user (especially if messages are delayed due to App can take minutes to show new msgs in a timeline (with no sync spinner) #1105 or bad network connectivity)
  4. Feel completely disoriented

Outcome

What did you expect?

You should see a local echo of the invite in the membership list, even if you haven't seen the remote echo of the invite yet. It could have a spinner or be greyed out or something to show that it's still sending.

What happened instead?

A feeling of extreme flakiness and nausea.

Your phone model

No response

Operating system version

No response

Application version

254

Homeserver

No response

Will you send logs?

No

@kittykat
Copy link
Contributor

@ara4n can you reproduce it after clearing cache?

I had a similar issue two weeks ago which was caused by matrix-org/matrix-rust-sdk#2078

@kittykat kittykat added X-Needs-Info This issue is blocked awaiting information from the reporter S-Critical Prevents work, causes data loss and/or has no workaround O-Occasional Affects or can be seen by some users regularly or most users rarely A-Room-List A-DMs labels Jun 28, 2023
@ara4n
Copy link
Member Author

ara4n commented Jun 28, 2023

I cleared cache, and can still repro it when inviting a new user.

@ara4n
Copy link
Member Author

ara4n commented Jun 28, 2023

after clearing cache, the "Pending" user turns up in the membership list though.

This is pretty horrid UX...

@ara4n ara4n added X-Maybe-Release-Blocker and removed X-Needs-Info This issue is blocked awaiting information from the reporter labels Jun 28, 2023
@ara4n ara4n changed the title Invites don't local echo. Invites don't local echo (or remote echo). Jun 29, 2023
@kittykat kittykat added A-Local echo Z-Schedule X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue and removed X-Maybe-Release-Blocker labels Jul 14, 2023
@kittykat kittykat changed the title Invites don't local echo (or remote echo). Invites in room membership list don't local echo (or remote echo). Jul 17, 2023
@pixlwave
Copy link
Member

With the network link conditioner set to 100% loss, sending an invite and returning to the timeline has no indication in the timeline that the invite was sent (or is pending to be sent). Turning off the conditioner gave me a error, followed by the invite appearing in the timeline.

Even without the network link conditioner, the membership list doesn't show the invited member even with the remote echo it seems, I needed to pop to the room details and push it back in again.

@Hywan Hywan assigned Hywan and jplatte and unassigned Hywan Aug 16, 2023
@jplatte
Copy link
Contributor

jplatte commented Sep 13, 2023

I don't think this is actually possible. EleWeb doesn't seem to create a local echo either. The invite endpoint does not have a transaction ID parameter that could be used to identify the event as belonging to the invite request (also, the invite response does not contain the event ID either).

@manuroe
Copy link
Member

manuroe commented Sep 15, 2023

I am deprioritising this feature because 1/ it would require specific work if we do not change the backend API and 2/ it does not exist elsewhere yet.

@manuroe manuroe added S-Major Severely degrades major functionality or product features, with no satisfactory workaround and removed S-Critical Prevents work, causes data loss and/or has no workaround Z-Schedule labels Sep 15, 2023
@manuroe
Copy link
Member

manuroe commented Jul 23, 2024

Tested it today. The member list refreshes at some point after, I guess, the backend acknowledges the request. The refresh can be instant or multi seconds according to network or matrix.org conditions.

Managing a local echo with all the retry mechanisms behind to make it reliable is a significant amount of work.

Why not displaying a banner like the one when the user is removing another member?

Image

@ara4n
Copy link
Member Author

ara4n commented Aug 21, 2024

also, the problem isn't just lack of local echo - but remote echo too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-DMs A-Local echo A-Room-List O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Maybe-Release-Blocker X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue
Projects
None yet
Development

No branches or pull requests

7 participants