Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timeline flashes stale messages on entering a room (especially after SS expiration) #1234

Closed
ara4n opened this issue Jul 4, 2023 · 4 comments
Closed

Timeline flashes stale messages on entering a room (especially after SS expiration) #1234

ara4n opened this issue Jul 4, 2023 · 4 comments
Labels
A-Timeline O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue

Comments

@ara4n
Copy link
Member

ara4n commented Jul 4, 2023 •
edited
Loading

Steps to reproduce

  1. Enter a room that you haven't viewed before in the current session (you may potentially need to wait for SS expiration)
  2. As the room history syncs, watch the timeline flicker / spasm for a few frames (showing stale messages from ~20 messages ago), and recover again.

This video shows what the flashing looks like (in this instance it's triggered by a proxy misconfiguration bug causing SS to expire every few seconds):

RPReplay_Final1688460989.mp4

Outcome

What did you expect?

Timeline that doesn't flicker horribly

What happened instead?

Flickering spasming timeline

Your phone model

No response

Operating system version

No response

Application version

271

Homeserver

No response

Will you send logs?

No
@ara4n ara4n added the T-Defect label Jul 4, 2023
@pixlwave pixlwave added X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue A-Timeline S-Minor Impairs non-critical functionality or suitable workarounds exist O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Jul 12, 2023
@ara4n
Copy link
Member Author

ara4n commented Aug 1, 2023

This now manifests itself as a an abrupt bouncing animation rather than a flash thanks to the timeline animations, which is slightly less undesirable but still a problem.

@ara4n
Copy link
Member Author

ara4n commented Sep 10, 2023

this still happens loads.

@ara4n
Copy link
Member Author

ara4n commented Oct 26, 2023

still happens.

@ara4n ara4n mentioned this issue Feb 10, 2024
Open
@ara4n ara4n mentioned this issue Mar 6, 2024
Open
4 tasks
@manuroe
Copy link
Member

manuroe commented Mar 27, 2024

I haven't seen it for a while

@manuroe manuroe closed this as completed Mar 27, 2024
pixlwave added a commit that referenced this issue Aug 13, 2024
@pixlwave
Add a danger check for PR titles that contain a "Fixes #1234" prefix.
7c416fa
pixlwave added a commit that referenced this issue Aug 13, 2024
@pixlwave
Add a danger check for PR titles that contain a "Fixes #1234" prefix.
6172a61
pixlwave added a commit that referenced this issue Aug 13, 2024
@pixlwave
Add a danger check for PR titles that contain a "Fixes #1234" prefix.
00d08f0
pixlwave added a commit that referenced this issue Aug 13, 2024
@pixlwave
Add a danger check for PR titles that contain a "Fixes #1234" prefix.
d41f1e5
pixlwave added a commit that referenced this issue Aug 13, 2024
@pixlwave
Add a danger check for PR titles that contain a "Fixes #1234" prefix.
32cc3bd
pixlwave added a commit that referenced this issue Aug 13, 2024
@pixlwave
Add a danger check for PR titles that contain a "Fixes #1234" prefix. (…
1384a72 
…#3161)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Timeline O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ara4n @pixlwave @manuroe