Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Room timelines flash raw matrix IDs before showing the profile displayname #1287

Closed
ara4n opened this issue Jul 8, 2023 · 2 comments
Closed
Labels
A-Timeline O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Tolerable Low/no impact on users T-Defect X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue

Comments

@ara4n
Copy link
Member

ara4n commented Jul 8, 2023

Steps to reproduce

  1. Open a largeish room
  2. At least some of the senders are shown with raw mxids and default avatars (i.e. without profiles) for a second or so
  3. And then the mxids resolve to actual displaynames.
  4. Feel unsettled at the clunkiness.

Looks like this:

RPReplay_Final1688834723.mov

Outcome

What did you expect?

We should have the correct profiles available to us from the m.room.member events in the room already; we shouldn't be "fixing up" the profiles in retrospect and thus the 'flash of markup' shouldn't be happening.

What happened instead?

flash of raw mxid, which is ugly and clunky and makes everything feel unpolished.

Your phone model

No response

Operating system version

No response

Application version

279

Homeserver

No response

Will you send logs?

No

@ara4n ara4n added the T-Defect label Jul 8, 2023
@pixlwave
Copy link
Member

This is a consequence of not including m.room.members in the sliding sync request to reduce its size. We load the m.room.members events upon creating the RoomProxy just before showing the room.

Maybe this will be fixed by having a cache again.

@pixlwave pixlwave added X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue A-Timeline S-Tolerable Low/no impact on users O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Jul 12, 2023
@stefanceriu
Copy link
Member

stefanceriu commented Jun 25, 2024

Haven't seen this in quite some time now, closing until hearing different

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Timeline O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Tolerable Low/no impact on users T-Defect X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue
Projects
None yet
Development

No branches or pull requests

3 participants