Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inability to distinguish between replies & threads (which could be a very easy fix) #1333

Closed
ara4n opened this issue Jul 15, 2023 · 9 comments
Labels
O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue

Comments

@ara4n
Copy link
Member

ara4n commented Jul 15, 2023

Steps to reproduce

  1. Chat in a room
  2. See a reply from someone - which happens to be inside a thread, but you have no way of knowing that.
  3. Answer it without sending a reply
  4. Your answer gets sent to the main timeline, fragmenting the thread, and making no sense to users on thread-aware clients.
  5. Feel frustrated that you broke the thread without realising it.

In other words: EX currently acts as a non-thread-aware client currently, showing threads as replies. Proper thread support is a while off.

However, if app showed you which replies were actually threads (and which were instead boring old replies), then the user would be able to much more effectively participate in threads - by knowing when they'd need to hit reply to participate in the thread, rather than talking normally in the room and fragmenting the thread for folks on thread-aware clients.

Outcome

What did you expect?

EX should tell me somehow which replies are actually threads, versus plain replies in the main timeline.

What happened instead?

EX doesn't, so as a user you don't know if you need to send an explicit reply in order to keep your message in the right place in the thread, or whether you can just send a normal non-reply message.

Your phone model

No response

Operating system version

No response

Application version

292

Homeserver

No response

Will you send logs?

No

@ara4n ara4n added the T-Defect label Jul 15, 2023
@stefanceriu stefanceriu added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue and removed T-Defect labels Jul 19, 2023
@ara4n
Copy link
Member Author

ara4n commented Jul 21, 2023

UI proposal: prefix the sender of the reply-preview message with 🧵 if the reply is part of a thread, until we have proper thread UI

@nadonomy
Copy link
Contributor

Your answer gets sent to the main timeline, fragmenting the thread, and making no sense to users on thread-aware clients.

Is this true? I've been using replies as a 'hack' on EX to reply in threads and at least a few weeks ago that was working great.

@ara4n
Copy link
Member Author

ara4n commented Aug 17, 2023

If you hit reply to the message, it's fine. The problem is that you don't know whether to hit reply or not, because you don't know if it's a thread, hence this bug.

@nadonomy
Copy link
Contributor

Aha gotcha (I'd misread point 3!).

@ara4n
Copy link
Member Author

ara4n commented Aug 17, 2023

Another thought: i wonder if we easily do very simple poor man's threading like iMessage does - i.e. hide messages from the timeline which aren't part of the thread if the user views a message. We could do this locally without having to use any server-side or even rust-sdk threading APIs as a first cut? (i.e. literally iterate over the timeline and hide the messages which aren't in the thread?)

@amshakal
Copy link

amshakal commented Aug 18, 2023

@stefanceriu @bmarty would this be easy to do? To 1) distinguish between threads and replies 2) to visually differentiate between the two without building the whole threads feature on EX 3) will this influence how notifications function on EX in any way?

@stefanceriu
Copy link
Member

  1. Sure, if the Rust SDK can provide us that piece of info on the timeline items
  2. Easy to tweak the timeline views, yes
  3. Not unless you want them to

@marwing
Copy link

marwing commented Oct 11, 2023

This was fixed by #1686 in 1.2.9, wasn't it?

@stefanceriu
Copy link
Member

This was fixed by #1686 in 1.2.9, wasn't it?

Yes, you're right. Fixed in #1686 which went out in 1.2.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue
Projects
None yet
Development

No branches or pull requests

5 participants