Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

State events should only be shown in the timeline if you have history visibility to see the timeline #1415

Closed
ara4n opened this issue Jul 27, 2023 · 2 comments
Closed

State events should only be shown in the timeline if you have history visibility to see the timeline #1415

ara4n opened this issue Jul 27, 2023 · 2 comments
Assignees
@stefanceriu
Labels
A-Timeline O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue Z-Polish

Comments

@ara4n
Copy link
Member

ara4n commented Jul 27, 2023

Steps to reproduce

  1. Accept an invite to a room with non-shared (ie invited/joined) history visibility.
  2. Scroll through pages of timeline showing historical membership events
  3. Get confused that it looks like the room has no actual messages
  4. Realise that they are hidden by histviz.
  5. Wince that we are technically leaking metadata by exposing the historical membership

Outcome

What did you expect?

Hide historical state events from users in the timeline which hist viz means they shouldn’t be able to see.

What happened instead?

the Mary Celeste

Your phone model

No response

Operating system version

No response

Application version

303

Homeserver

No response

Will you send logs?

No
@Velin92 Velin92 added X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely A-Timeline labels Jul 28, 2023
@ara4n
Copy link
Member Author

ara4n commented Jul 28, 2023

this may be a bogus bug in the end; i think the room genuinely had no non-stateevents in it. but would be good to check.

@stefanceriu stefanceriu self-assigned this Sep 8, 2023
@stefanceriu
Copy link
Member

This is indeed the case but ElementX behaves in line with our other clients:

iOS Web Element X
IMG_79FD8C38FFBB-1 Screenshot 2023-09-11 at 14 18 44 Screenshot 2023-09-11 at 14 23 11

As such this is a bigger discussions that should be taken through the proper channels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stefanceriu stefanceriu

Labels
A-Timeline O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue Z-Polish
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kittykat @stefanceriu @ara4n @Velin92