Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replies to messages sent before the blue "Message history is currently unavailable in this room" warning don't show as replies. #1429

Closed
ara4n opened this issue Jul 31, 2023 · 2 comments
Labels
A-Timeline O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue

Comments

@ara4n
Copy link
Member

ara4n commented Jul 31, 2023

Steps to reproduce

  1. Logout
  2. Log in again
  3. Have someone send a reply (in an E2EE room?) to a message which predates you logging back in.
  4. Nothing shows the message in the timeline as being a reply.

(when trying to take a screenshot of this, after upgrading to build 312, the placeholders were shown however - so either this got fixed in 312, or it's racey. i'd assume the latter)

Example impacted message:

EventTimelineItem {
    sender: "@neilj:matrix.org",
    sender_profile: Ready(
        Profile {
            display_name: Some(
                "neil",
            ),
            display_name_ambiguous: false,
            avatar_url: Some(
                "mxc://matrix.org/DIGiJjzKkVsWwpppAcrGRwzB",
            ),
        },
    ),
    timestamp: MilliSecondsSinceUnixEpoch(1690805798001),
    content: Message(
        Message {
            in_reply_to: Some(
                InReplyToDetails {
                    event_id: "$16905358540PHnkf:vector.modular.im",
                    event: Ready(
                        RepliedToEvent {
                            content: UnableToDecrypt(
                                MegolmV1AesSha2 {
                                    sender_key: "K74nDFQaaz0eKKl7+KGxC9kFTtZ5926Z40c95Ka3oFU",
                                    device_id: "ZKMQGOKYWM",
                                    session_id: "NXOHJ8ZUfgD33naOQjsd9SIrqJN+KmbCHy7NtX5Y2Uo",
                                },
                            ),
                            sender: "@rxl881:vector.modular.im",
                            sender_profile: Ready(
                                Profile {
                                    display_name: Some(
                                        "Rick",
                                    ),
                                    display_name_ambiguous: false,
                                    avatar_url: Some(
                                        "mxc://vector.modular.im/oGztPLmeVospzXFVswsfoleD",
                                    ),
                                },
                            ),
                        },
                    ),
                },
            ),
            edited: false,
            ..
        },
    ),
    kind: Remote(
        RemoteEventTimelineItem {
            event_id: "$169080579841297xSzRJ:matrix.org",
            reactions: {
                "👍\u{fe0f}": ReactionGroup(
                    {
                        EventId(
                            "$16908067370vDhAy:vector.modular.im",
                        ): ReactionSenderData {
                            sender_id: "@rxl881:vector.modular.im",
                            timestamp: MilliSecondsSinceUnixEpoch(1690806737441),
                        },
                    },
                ),
            },
            read_receipts: {},
            is_own: false,
            is_highlighted: false,
            encryption_info: Some(
                EncryptionInfo {
                    sender: "@neilj:matrix.org",
                    sender_device: Some(
                        "QSJYYMRMNL",
                    ),
                    algorithm_info: MegolmV1AesSha2 {
                        curve25519_key: "WFKXc6GuQ7HCC7fzx4GeEmzTsXk6i7+x0eizKXMX5hE",
                        sender_claimed_keys: {
                            "ed25519": "WmMm5bcNdjwn4erVD+9xXpm9edxT2tH8usmIR7lmMi0",
                        },
                    },
                    verification_state: Verified,
                },
            ),
            origin: Sync,
            ..
        },
    ),
}

{
  "sender" : "@neilj:matrix.org",
  "content" : {
    "body" : "> <@rxl881:vector.modular.im> Gahh... FFS \n\nWell this is no good. Here is the [latest](https:\/\/github.com\/vector-im\/element-web\/issues\/24392#issuecomment-1645296844) on the notifications project. ",
    "formatted_body" : "<mx-reply><blockquote><a href=\"https:\/\/matrix.to\/#\/!GBouwXXSNlkxuUiduy:matrix.org\/$16905358540PHnkf:vector.modular.im?via=matrix.org&via=vector.modular.im&via=beta.matrix.org\">In reply to<\/a> <a href=\"https:\/\/matrix.to\/#\/@rxl881:vector.modular.im\">@rxl881:vector.modular.im<\/a><br>Gahh... FFS<\/blockquote><\/mx-reply>Well this is no good. Here is the <a href=\"https:\/\/github.com\/vector-im\/element-web\/issues\/24392#issuecomment-1645296844\">latest<\/a> on the notifications project.",
    "msgtype" : "m.text",
    "m.relates_to" : {
      "m.in_reply_to" : {
        "event_id" : "$16905358540PHnkf:vector.modular.im"
      }
    },
    "format" : "org.matrix.custom.html"
  },
  "origin_server_ts" : 1690805798001,
  "room_id" : "!GBouwXXSNlkxuUiduy:matrix.org",
  "event_id" : "$169080579841297xSzRJ:matrix.org",
  "type" : "m.room.message",
  "unsigned" : {
    "age" : 114
  }
}

Outcome

What did you expect?

Replies should show a placeholder to the thing they're replying to, even if that message isn't available to the client.

What happened instead?

There's zero indication that these messages were replies

Your phone model

No response

Operating system version

No response

Application version

312

Homeserver

No response

Will you send logs?

No

@ara4n ara4n added the T-Defect label Jul 31, 2023
@stefanceriu stefanceriu added X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue A-Timeline S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Aug 8, 2023
@alphatownsman
Copy link

Sorry for a bit off topic. Is there an existing issue for "message history currently unavailable"? Trying to understand how and when this can be resolved.

@VolkerJunginger
Copy link

Cannot reproduce w. the app supporting keybackup now.

@VolkerJunginger VolkerJunginger closed this as not planned Won't fix, can't repro, duplicate, stale Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Timeline O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue
Projects
None yet
Development

No branches or pull requests

4 participants