Sync spinner missing ~70% of the time I foreground the app

[ara4n]

Steps to reproduce

1. Have a big account
2. Foreground the app
3. See no sync spinner, but rooms are ~5 minutes old
4. After waiting for up to ~10s (Launch time has regressed substantially. #1509) the room list suddenly updates.

This began after #1562 was merged

@stefanceriu's theory is that the app thinks a background refresh is in progress, hence not showing a spinner. But empirically it isn't.

Outcome

What did you expect?

Spinner when the app is showing me stale data and trying to sync.

What happened instead?

No spinner

Your phone model

No response

Operating system version

No response

Application version

364

Homeserver

No response

Will you send logs?

Yes

[ara4n]

having disabled background refresh in OS settings, i'm not seeing this misbehaviour any more.

@stefanceriu: it sounds like background refresh could very legitimately get stuck, given it might have a lot of data to sync in the bg, be very ratelimited in the app, and also be on terrible data (given the user could be wandering around making no attempt for the app to be in good connectivity given they're not actively using it - e.g. on a train). Is there a way for the app to knife bg refresh and start over it's stuck when it's foregrounded, in order to get the sync spinner back again?

[manuroe]

Seems to be solved now