Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tinted avatar can be different in the room setting screen #1659

Closed
manuroe opened this issue Sep 8, 2023 · 3 comments · Fixed by #2900
Closed

Tinted avatar can be different in the room setting screen #1659

manuroe opened this issue Sep 8, 2023 · 3 comments · Fixed by #2900
Labels
A-Room-Detail O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue

Comments

@manuroe
Copy link
Member

manuroe commented Sep 8, 2023 •
edited
Loading

I saw the problem in a single DM. It may be a race condition: killing the app does not fix the problem but clearing the cache, yes.

In the room list and in the timeline:
IMG_8072

In the DM room:
IMG_8073
@manuroe manuroe added T-Defect S-Minor Impairs non-critical functionality or suitable workarounds exist O-Uncommon Most users are unlikely to come across this or unexpected workflow A-Room-Detail labels Sep 8, 2023
@Velin92
Copy link
Member

Velin92 commented Sep 8, 2023 •
edited
Loading

I double checked it and this issue is actually well... expected.
The DM Room details uses the user ID as hash for the color, while the list, and the header in the timeline use the room ID for the has in the color since as of right now we don't have in those the userID of the dm recipient yet.

This also applies for notifications, they use the user id to generate the placeholder for a dm, not the room id.

The details color is essentially correct.
The room list is the wrong one, but we need the heroes to fix it.

@pixlwave pixlwave mentioned this issue Oct 11, 2023
Closed
@pixlwave
Copy link
Member

Note: matrix-org/sliding-sync#241 has been added now, so changing this to needs Rust instead of needs Backend.

@pixlwave pixlwave added X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue and removed X-Needs-Backend labels Oct 11, 2023
@pixlwave
Copy link
Member

Created matrix-org/matrix-rust-sdk#2702 to track this.

@HarHarLinks HarHarLinks mentioned this issue Oct 18, 2023
Closed
This was referenced Jun 3, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Room-Detail O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use the room heroes when computing a DM avatar. element-hq/element-x-ios
3 participants
@pixlwave @manuroe @Velin92