Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push notifications leak HTML + Markdown in rich messages #1679

Closed
ara4n opened this issue Sep 11, 2023 · 0 comments · Fixed by #1688
Closed

Push notifications leak HTML + Markdown in rich messages #1679

ara4n opened this issue Sep 11, 2023 · 0 comments · Fixed by #1688
Assignees
Labels
A-Notifications O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@ara4n
Copy link
Member

ara4n commented Sep 11, 2023

Steps to reproduce

  1. Receive a push with a rich message
  2. Observe that it shows the raw body of the message, which includes MD (and by extension HTML) formatting, which looks ugly and unprofessional. The recipient doesn't care what markup the sender used to write the message; they care about reading its contents instead.

e.g.

IMG_2858
IMG_2857

Outcome

What did you expect?

HTML of rich msgs should be 'flattened' to plaintext to be rendered in notifications, stripping out the tags.

(It's interesting that in this example with bnjbvr, the sense of the message would have been lost, however, by stripping out the tags. Perhaps we leave semantically important tags in place.)

What happened instead?

Ugly mix of MD & tags in notifs.

Your phone model

No response

Operating system version

No response

Application version

380

Homeserver

No response

Will you send logs?

No

@ara4n ara4n added the T-Defect label Sep 11, 2023
@stefanceriu stefanceriu self-assigned this Sep 11, 2023
@stefanceriu stefanceriu added S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Occasional Affects or can be seen by some users regularly or most users rarely A-Notifications Z-Schedule labels Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Notifications O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants