Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Element X doesn't check that the proxy responses are 2xx #1701

Open
thibaultamartin opened this issue Sep 13, 2023 · 3 comments
Open

Element X doesn't check that the proxy responses are 2xx #1701

thibaultamartin opened this issue Sep 13, 2023 · 3 comments
Labels
A-Sync O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue

Comments

@thibaultamartin
Copy link

Steps to reproduce

  1. Deploy a homeserver on matrix.example.com behind a reverse proxy
  2. Update the .well-known/matrix/client file so it responds the "org.matrix.msc3575.proxy": {"url": "https://matrix.example.com"}
  3. Log in with Element X to example.com. The sync screen beings
  4. The reverse proxy returns 404s for the sliding sync endpoints
  5. Element X keeps spinning on the initial sync, not detecting that the sliding sync proxy is not here/not working

Outcome

What did you expect?

I expected the client to tell me that something's wrong

What happened instead?

The client tells me to wait forever

Your phone model

iPhone 11 Pro

Operating system version

iOS 17

Application version

Element X TF 1.2.9 (3)

Homeserver

Synapse 1.91 + Sliding Sync Proxy 0.99.10

Will you send logs?

No

@stefanceriu stefanceriu added X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue A-Sync S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Oct 4, 2023
@pixlwave
Copy link
Member

pixlwave commented Oct 9, 2023

From #1866:

Steps to reproduce

  1. Set up synapse and a sliding sync server. Both available on :8448, synapse on :443 as well.
  2. Forget to expose the sliding sync server on :443
  3. Configure the .well-known to point to both servers (in my case: two subdomains, same apache)
  4. Log in to server in Element X

Outcome

What did you expect?

  • Element X figures out the host is not reachable and errors out

What happened instead?

  • I am able to get all the way to "Setting up your account, this may take a while"
  • Element X keeps on spinning, the phone gets fairly warm (though that might not be related)
  • Sliding sync server obviously never gets contacted
  • Even if I fully quit the app and restart it, it goes back to the spinning immediately

Application version

1.3.1 (74)

Homeserver

Synapse 1.93.0 / Sliding Sync 0.99.10

@teon
Copy link

teon commented Apr 16, 2024

Same here. I forgot to add to my DNS the sync host domain and had Setting up your account, this may take a while indefinitely...
Thanks to @pixlwave and this issue I got an idea how to fixed it ;-)

@pixlwave
Copy link
Member

Linking this to matrix-org/matrix-rust-sdk#2822 which is what we need to detect the failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Sync O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue
Projects
None yet
Development

No branches or pull requests

4 participants