Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bloom flashes green on launch #1745

Open
ara4n opened this issue Sep 18, 2023 · 3 comments
Open

Bloom flashes green on launch #1745

ara4n opened this issue Sep 18, 2023 · 3 comments
Labels
A-Room-List A-User-Detail O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users T-Defect X-Needs-Design

Comments

@ara4n
Copy link
Member

ara4n commented Sep 18, 2023

Steps to reproduce

  • When the app launches, the avatar hasn’t loaded yet
  • Therefore the default avatar is shown, and you see a flash of green (or similar) bloom for about 200ms:

IMG_2951

Outcome

What did you expect?

  • Cache my avatar
  • Cache the bloom

What happened instead?

Weird green flash.

Your phone model

No response

Operating system version

No response

Application version

388

Homeserver

No response

Will you send logs?

No

@Velin92
Copy link
Member

Velin92 commented Sep 19, 2023

Maybe we should delay the appearence of the bloom by half a second (since even if you are not connected we have the avatar image cached so it wlll definitely appear after half a second) and then make the bloom fade in as it does right now?
@janogarcia

I will also see if I can preload the cached image so that it displays immediately, without slowing the UI

@janogarcia
Copy link

@Velin92 Preferably, preload the cached image avatar. We may still need to update the avatar at some point after syncing if the user happened to change her avatar while the client was offline.

If preloading is not feasible (I hope it is) and we need to introduce a delay as a fallback, then please only perform it on initial load/sync, making sure we don't introduce it on regular transitions (e.g., going from a room back to the room list). 👍

@ara4n
Copy link
Member Author

ara4n commented Sep 22, 2023

it would be a super hacky bodge to put in a sleep rather than cache the avatar correctly... to be clear, the flash lasts for at least 100 milliseconds already

@stefanceriu stefanceriu added X-Needs-Design A-Room-List T-Defect S-Tolerable Low/no impact on users O-Occasional Affects or can be seen by some users regularly or most users rarely A-User-Detail labels Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Room-List A-User-Detail O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users T-Defect X-Needs-Design
Projects
None yet
Development

No branches or pull requests

4 participants