Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock screen grace period is *very* confusing and insecure #2011

Closed
ara4n opened this issue Nov 1, 2023 · 1 comment · Fixed by #2014
Closed

Lock screen grace period is *very* confusing and insecure #2011

ara4n opened this issue Nov 1, 2023 · 1 comment · Fixed by #2014
Labels
A-App-Lock O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@ara4n
Copy link
Member

ara4n commented Nov 1, 2023

Steps to reproduce

  1. Enable lock screen
  2. Launch the app
  3. Enter your PIN code
  4. Feel nice and secure
  5. A few minutes later, hand someone your phone so they can enter their phone number / order takeaway / futz with venmo / etc
  6. Discover that they were able to a) view the contents of Element in the task switcher, b) switch to the app and read your messages.

Outcome

What did you expect?

I'd expect the PIN to be prompted for every single time you foreground the app, at least by default, otherwise its security is very questionable indeed. I'd also expect the UI of the app to be hidden as soon as it gets backgrounded, to avoid people shouldersurfing the task switcher (or iOS from caching sensitive content for the task switcher sprites)

Critically, the app should behave like WhatsApp or banking apps which default to having no grace period.

What happened instead?

A confusing setup where some of the time you get prompted for PINs by the app, and sometimes you don't, and the user doesn't know when they're protected or not.

Your phone model

No response

Operating system version

No response

Application version

424

Homeserver

No response

Will you send logs?

No

@ara4n ara4n added the T-Defect label Nov 1, 2023
@pixlwave
Copy link
Member

pixlwave commented Nov 2, 2023

We're going to set the grace period to 0 and let forks set a custom value if they want that behaviour.

@pixlwave pixlwave added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely A-App-Lock labels Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-App-Lock O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants